Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(621)

Issue 5834047: state: simplify test initialization given new zookeeper functionality.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rog
Modified:
12 years, 1 month ago
Reviewers:
mp+97624, TheMue
Visibility:
Public.

Description

Also moved ZkSetupEnvironment into state_test.go as it's nicer, I think, to let export_test.go highlight exactly the exported variables and functions. https://code.launchpad.net/~rogpeppe/juju/go-state-changes-for-zk-interface/+merge/97624 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: simplify test initialization given new zookeeper functionality. #

Patch Set 3 : state: simplify test initialization given new zookeeper functionality. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -34 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M state/export_test.go View 1 chunk +0 lines, -32 lines 0 comments Download
M state/state_test.go View 1 2 2 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
12 years, 1 month ago (2012-03-15 12:08:49 UTC) #1
TheMue
On 2012/03/15 12:08:49, rog wrote: > Please take a look. LGTM
12 years, 1 month ago (2012-03-15 12:16:24 UTC) #2
rog
12 years, 1 month ago (2012-03-15 12:19:27 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b