Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(336)

Issue 583160043: Issue 5593: Optionally use "tidy" to check generated HTML (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by Dan Eble
Modified:
1 day, 5 hours ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5593/ 1: use "false" for missing programs STEPMAKE_OPTIONAL_REQUIRED sets "false" for a missing program, whether required or optional. I removed a comment suggesting to abort immediately when a required program is missing; that would be less helpful than the current behavior of reporting all missing programs when the script is done. Thanks to Jonas Hahnfeld <hahnjo@hahnjo.de> for correcting a misunderstanding I had about this code, leading to this improvement. 2: optionally use "tidy" to check generated HTML I found the program "tidy" to be somewhat useful for catching problems like empty or unclosed tags in the HTML generated by output-distance, so I added it to the build as an option. http://validator.w3.org caught a few more problems, but tidy is fast and I didn't see it raise any incorrect objections, so it seems beneficial to use it when it is available.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M GNUmakefile.in View 1 chunk +7 lines, -1 line 0 comments Download
M aclocal.m4 View 3 chunks +9 lines, -12 lines 0 comments Download
M config.make.in View 1 chunk +1 line, -0 lines 0 comments Download
M configure.ac View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Dan Eble
no change
1 week, 5 days ago (2019-11-05 14:42:31 UTC) #1
Dan Eble
no change
1 week, 5 days ago (2019-11-05 14:48:30 UTC) #2
Dan Eble
no change
1 week, 5 days ago (2019-11-05 14:52:19 UTC) #3
Dan Eble
no change
1 week, 5 days ago (2019-11-05 14:56:07 UTC) #4
hahnjo
1 week, 5 days ago (2019-11-05 16:29:28 UTC) #5
I even like this better than my original version, always having false for a
missing program sounds like a good idea.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b