Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14600)

Issue 58170045: bootstrap: Added configurable timeout and delays (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by dimitern
Modified:
10 years, 2 months ago
Reviewers:
mp+203832, natefinch
Visibility:
Public.

Description

bootstrap: Added configurable timeout and delays Fixed bug #1257649: ssh timeout for bootstrap could be configurable, by adding 3 new config settings: - bootstrap-timeout (default: 600s = 10m) - bootstrap-retry-delay (default: 5s) - bootstrap-addresses-delay (default: 10s) All of them are integers, measured in seconds, and also all of them are optional and have the specified defaults. Updated the bootstrap command's help text to include the new config settings. https://code.launchpad.net/~dimitern/juju-core/270-lp-1257649-ssh-timeout-bootstrap/+merge/203832 Requires: https://code.launchpad.net/~dimitern/juju-core/260-lp-1067979-duplicate-charm/+merge/203291 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : bootstrap: Added configurable timeout and delays #

Patch Set 3 : bootstrap: Added configurable timeout and delays #

Patch Set 4 : bootstrap: Added configurable timeout and delays #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -54 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/bootstrap.go View 1 2 3 1 chunk +10 lines, -1 line 0 comments Download
M environs/config/config.go View 1 2 3 7 chunks +78 lines, -15 lines 0 comments Download
M environs/config/config_test.go View 1 2 3 5 chunks +86 lines, -3 lines 0 comments Download
M provider/common/bootstrap.go View 1 2 3 5 chunks +11 lines, -33 lines 0 comments Download
M provider/common/bootstrap_test.go View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
dimitern
Please take a look.
10 years, 2 months ago (2014-01-29 20:02:19 UTC) #1
natefinch
Please remove all user-facing mentions of SSH, since that's an internal detail and something that ...
10 years, 2 months ago (2014-01-29 20:10:49 UTC) #2
natefinch
Oh yeah, otherwise LGTM :)
10 years, 2 months ago (2014-01-29 20:11:09 UTC) #3
dimitern
Please take a look.
10 years, 2 months ago (2014-01-29 21:08:29 UTC) #4
dimitern
Please take a look.
10 years, 2 months ago (2014-01-30 14:18:16 UTC) #5
dimitern
10 years, 2 months ago (2014-01-30 17:29:15 UTC) #6
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b