Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 581610043: parser-ly-from-scheme: Make #{ compilable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by dak
Modified:
1 week, 2 days ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

parser-ly-from-scheme: Make #{ compilable For better or worse, Guile 2 has problems byte-compiling function values. Factor out the previous internal function read-lily-expression-internal and refer to it by (module-relative) name rather than value in Guile 2.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M scm/parser-ly-from-scheme.scm View 2 chunks +11 lines, -11 lines 2 comments Download

Messages

Total messages: 3
thomasmorley651
Afaict, LGTM A remark: https://codereview.appspot.com/581610043/diff/569310043/scm/parser-ly-from-scheme.scm File scm/parser-ly-from-scheme.scm (right): https://codereview.appspot.com/581610043/diff/569310043/scm/parser-ly-from-scheme.scm#newcode19 scm/parser-ly-from-scheme.scm:19: (define (read-lily-expression-internal lily-string filename line ...
2 weeks, 6 days ago (2020-02-08 20:35:49 UTC) #1
dak
https://codereview.appspot.com/581610043/diff/569310043/scm/parser-ly-from-scheme.scm File scm/parser-ly-from-scheme.scm (right): https://codereview.appspot.com/581610043/diff/569310043/scm/parser-ly-from-scheme.scm#newcode19 scm/parser-ly-from-scheme.scm:19: (define (read-lily-expression-internal lily-string filename line closures) On 2020/02/08 20:35:49, ...
2 weeks, 6 days ago (2020-02-08 22:02:59 UTC) #2
thomasmorley651
2 weeks, 6 days ago (2020-02-08 22:39:38 UTC) #3
On 2020/02/08 22:02:59, dak wrote:

> Uh, is this the right issue to discuss this with?  

Likely not, I opened a thread on -devel.


> Are you completely sure that you are using a version of LilyPond compiled with
> Guile-2.2.6?  

At least 
$ lilypond-git scheme-sandbox

returns:

GNU LilyPond 2.21.0
Processing
`/home/hermann/lilypond-git/build/out/share/lilypond/current/ly/scheme-sandbox.ly'
Parsing...
GNU Guile 2.2.6.7-9a11b
[...]
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b