Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1636)

Issue 5815043: Add regtest directory for svg output (issue 2230). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Julien Rioux
Modified:
6 years, 9 months ago
Reviewers:
Graham Percival, MikeSol, phileholmes, PhilEHolmes
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Add regtest directory for svg output (issue 2230).

Patch Set 1 #

Patch Set 2 : Fix make check on empty directory. #

Patch Set 3 : Fix make check on new directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -22 lines) Patch
M GNUmakefile.in View 3 chunks +4 lines, -1 line 0 comments Download
M input/regression/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
A input/regression/svg/GNUmakefile View 1 chunk +23 lines, -0 lines 0 comments Download
M scripts/build/lys-to-tely.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/output-distance.py View 1 2 5 chunks +27 lines, -19 lines 0 comments Download

Messages

Total messages: 4
Julien Rioux
Please review.
7 years, 3 months ago (2012-03-13 21:15:35 UTC) #1
Graham Percival
The only problem I can imagine is: what version of imagemagick is in GUB, and ...
7 years, 3 months ago (2012-03-13 21:43:45 UTC) #2
Julien Rioux
On 2012/03/13 21:43:45, Graham Percival wrote: > The only problem I can imagine is: what ...
7 years, 3 months ago (2012-03-13 21:46:48 UTC) #3
PhilEHolmes
7 years, 3 months ago (2012-03-14 09:04:39 UTC) #4
Insofar as I don't fully follow this, LGTM.  Have you tested by changing an
input file and confirming that the regtest checker picks it up?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b