Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(353)

Issue 579630043: Minor cleanups in stencil-integral.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by hanwenn
Modified:
3 years, 11 months ago
Reviewers:
dak, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Minor cleanups in stencil-integral.cc

Patch Set 1 #

Patch Set 2 : save another curve_point call #

Patch Set 3 : comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M lily/stencil-integral.cc View 1 2 3 chunks +18 lines, -17 lines 2 comments Download

Messages

Total messages: 10
hanwenn
save another curve_point call
3 years, 11 months ago (2020-04-24 21:01:52 UTC) #1
hanwenn
comment
3 years, 11 months ago (2020-04-24 21:04:28 UTC) #2
dak
https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc#newcode465 lily/stencil-integral.cc:465: // more convoluted, but it's fairly hot path. Sorry ...
3 years, 11 months ago (2020-04-24 21:18:12 UTC) #3
dak
On 2020/04/24 21:18:12, dak wrote: > https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc > File lily/stencil-integral.cc (right): > > https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc#newcode465 > ...
3 years, 11 months ago (2020-04-24 21:19:57 UTC) #4
Carl
On 2020/04/24 21:19:57, dak wrote: > On 2020/04/24 21:18:12, dak wrote: > > > https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc ...
3 years, 11 months ago (2020-04-24 21:33:12 UTC) #5
dak
On 2020/04/24 21:33:12, Carl wrote: > On 2020/04/24 21:19:57, dak wrote: > > On 2020/04/24 ...
3 years, 11 months ago (2020-04-24 22:04:52 UTC) #6
hanwenn
On 2020/04/24 22:04:52, dak wrote: > On 2020/04/24 21:33:12, Carl wrote: > > On 2020/04/24 ...
3 years, 11 months ago (2020-04-25 07:29:06 UTC) #7
dak
On 2020/04/25 07:29:06, hanwenn wrote: > On 2020/04/24 22:04:52, dak wrote: > > On 2020/04/24 ...
3 years, 11 months ago (2020-04-25 08:32:40 UTC) #8
hanwenn
On 2020/04/25 08:32:40, dak wrote: > > I have plans to do this, but they ...
3 years, 11 months ago (2020-04-25 11:43:59 UTC) #9
hanwenn
3 years, 11 months ago (2020-05-02 22:26:12 UTC) #10
https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):

https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral...
lily/stencil-integral.cc:465: // more convoluted, but it's fairly hot path.
On 2020/04/24 21:18:12, dak wrote:
> Sorry for not being clear: the question was not why this change was effective
in
> saving time, but why it was valid.  When thickness is zero, you only update
the
> upper skyline.  Why would the lower skyline no longer need updating?

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b