Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1083)

Issue 5796052: Allow music in contextmods (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by dak
Modified:
7 years, 2 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Allow music in contextmods so that one can say \new Staff \with { \clef bass } { ... } or similar. It turns out that \time ... is rather elusive to get to work in such circumstances (context mod or output def) since the alias for the Timing context is established by the Timing_engraver, namely _after_ the context modifications have already been set up. Apart from that, most other things work nicely. Consists of three subpatches: Use elements-callback for layout-instruction event reinterpretation Allow music in contextmods Implement 'apply context mod

Patch Set 1 #

Patch Set 2 : Now does everything needed for \layout { \time 3/4 }. Contains several patches. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -66 lines) Patch
M lily/context-def.cc View 1 2 chunks +14 lines, -1 line 0 comments Download
M lily/context-property.cc View 1 chunk +12 lines, -3 lines 0 comments Download
M lily/include/context-def.hh View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/output-def-scheme.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download
M lily/parser.yy View 5 chunks +33 lines, -18 lines 0 comments Download
M lily/timing-translator.cc View 1 2 chunks +25 lines, -8 lines 0 comments Download
M ly/declarations-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 1 chunk +8 lines, -1 line 0 comments Download
M ly/music-functions-init.ly View 1 chunk +9 lines, -3 lines 0 comments Download
M ly/performer-init.ly View 1 1 chunk +17 lines, -0 lines 0 comments Download
M scm/lily-library.scm View 1 2 chunks +76 lines, -32 lines 0 comments Download

Messages

Total messages: 1
janek
7 years, 3 months ago (2012-03-10 21:48:56 UTC) #1
David,

i'm sorry because i cannot give your patch a proper review, but i appreciate
your work.  I think Lily really needs changes like this.

thanks,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b