Remove compat hack for Solaris7 and HP-UX

Remove compat hack for Solaris7 and HP-UX

Solaris 7 reached EOL in August 2008. Nobody runs HP-UX anymore.

[lemzwerg, 2020-03-15 15:41:38]

LGTM

[dak, 2020-03-15 16:47:55]

https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4
File aclocal.m4 (right):

https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4#newcode694
aclocal.m4:694: AC_PATH_PROG(BASH, bash, $SHELL)
This sets BASH with a fallback to /bin/sh , meaning that $BASH is not guaranteed
to be anything remotely likely to Bash.

And in the current code base, it would not appear that $BASH is even getting
used anywhere.  At least I cannot find anything suggesting its use  (rather than
its maintenance) with

git grep BASH origin

So what is supposed to be the idea with $BASH here?  What is it supposed to
guarantee providing, and where is it supposed to (eventually?) get used?

[hanwenn, 2020-03-15 18:03:42]

remove more bash.

[hanwenn, 2020-03-15 18:07:10]

On 2020/03/15 16:47:55, dak wrote:
> https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4
> File aclocal.m4 (right):
> 
> https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4#newcode694
> aclocal.m4:694: AC_PATH_PROG(BASH, bash, $SHELL)
> This sets BASH with a fallback to /bin/sh , meaning that $BASH is not
guaranteed
> to be anything remotely likely to Bash.
> 
> And in the current code base, it would not appear that $BASH is even getting
> used anywhere.  At least I cannot find anything suggesting its use  (rather
than
> its maintenance) with
> 
> git grep BASH origin
> 
> So what is supposed to be the idea with $BASH here?  What is it supposed to
> guarantee providing, and where is it supposed to (eventually?) get used?

I removed all things BASH for now.

We might want to consider hardcoding all our shell scripts to /bin/bash, though.

[hanwenn, 2020-03-21 12:28:12]

commit bbc9f3a208d17670d729bfc08e4b28b0a590bf6f (origin/staging, origin/master)
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Sun Mar 15 16:08:50 2020 +0100

    Remove @BASH@.
    
    Remove compat hack for Solaris7 and HP-UX (Solaris 7 reached EOL in
    August 2008. Nobody runs HP-UX anymore.)
    
    https://sourceforge.net/p/testlilyissues/issues/5846
    http://codereview.appspot.com/579480047