Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(291)

Issue 579140043: Issue 5624: ignore \barNumberCheck when processing MIDI (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Dan Eble
Modified:
4 years, 3 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5624/ Make bar number checks contingent on the new context property ignoreBarNumberChecks not being true. Set it by default in the MIDI Score context. Reword the warning message to avoid confusion with bar checks. Eliminate input/regression/bar-number-check.ly because it seemed to duplicate coverage.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -33 lines) Patch
D input/regression/bar-number-check.ly View 1 chunk +0 lines, -19 lines 0 comments Download
M input/regression/bar-number-check-warning.ly View 1 chunk +25 lines, -9 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +6 lines, -5 lines 1 comment Download
M ly/performer-init.ly View 1 chunk +4 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
Dan Eble
4 years, 4 months ago (2019-11-28 00:50:38 UTC) #1
lemzwerg
LGTM, thanks! https://codereview.appspot.com/579140043/diff/549240043/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/579140043/diff/549240043/ly/music-functions-init.ly#newcode243 ly/music-functions-init.ly:243: (if (and (number? cbn) (not (= cbn ...
4 years, 4 months ago (2019-11-28 06:16:00 UTC) #2
Dan Eble
4 years, 4 months ago (2019-11-28 13:13:47 UTC) #3
On 2019/11/28 06:16:00, lemzwerg wrote:
>
https://codereview.appspot.com/579140043/diff/549240043/ly/music-functions-in...
> ly/music-functions-init.ly:243: (if (and  (number? cbn) (not (= cbn n)))
> Is there a special reason to retain the two spaces here?

I'll fix it locally and make check, but I won't update the review for it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b