Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1795)

Issue 5784084: Fix mordents and pralltriller in articulate.ly

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Peter Chubb
Modified:
7 years, 3 months ago
Reviewers:
Graham Percival, peter.chubb
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Fix mordents and pralltriller in articulate.ly Mordents should be on-beat, not grace notes. And pralltrillers (half-shakes) are always either 4 alternating notes, or an inverted mordent. There is of course a general problem here in that the way ornaments are realised has changed through the centuries. Even Bach and Clementi disagree! I'm following CPE Bach's `True art of Keyboard Playing' in the interpretation here. To do the job properly we'd have two articulations: \prall and \inverted_mordent and treat them separately for MIDI, but typeset the same glyph. Reported-by: Christopher Maden <crism@maden.org> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix mordent duration #

Patch Set 3 : Fix mordents and pralltriller in articulate.ly #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -7 lines) Patch
M ly/articulate.ly View 1 2 chunks +57 lines, -7 lines 1 comment Download

Messages

Total messages: 4
Peter Chubb
I stuffed up adding the patch initially (ended up with a reverse patch for a ...
7 years, 3 months ago (2012-03-15 01:12:11 UTC) #1
Graham Percival
ok. In the future, when updating a patch, please point git-cl at your existing issue ...
7 years, 3 months ago (2012-03-15 01:32:34 UTC) #2
peter.chubb_nicta.com.au
>>>>> "graham" == graham <graham@percival-music.ca> writes: graham> ok. In the future, when updating a patch, ...
7 years, 3 months ago (2012-03-15 03:49:49 UTC) #3
Graham Percival
7 years, 3 months ago (2012-03-15 04:10:14 UTC) #4
On Thu, Mar 15, 2012 at 02:49:29PM +1100, Peter Chubb wrote:
> >>>>> "graham" == graham  <graham@percival-music.ca> writes:
> 
> graham> ok.  In the future, when updating a patch, please point git-cl
> graham> at your existing issue (which was orginally 2404, but I'm
> graham> going to close 2404 and 2405 and leave 2406).
> 
> Can I do that in .git/config?

Unfortunately not.

>  It currently points at a Rietveld issue  5784084
>  --- I wasn't aware that there was a separate Lilypond issue number
>  name space.  Is git-cl meant to print out the new Lilypond issue number? 

git-cl will say "I can't find an issue number"; at that point,
manually type in 2406.

Hopefully somebody will add code.google-issue-number-tracking to
git-cl at some point, but that's not likely to happen soon.

> I think the (begin is unnecessary too.  I was a real novice scheme
> programmer when I wrote all this --- still am. The body of a let
> clause is already a list of fucntion calls.

Well, each patch will need to go through the review.  You could
let the current ones go through, then do more edits; or you could
cancel the current one, make more edits, then send a single patch
through.

- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b