Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(768)

Issue 5777048: code review 5777048: runtime: add interface microbenchmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by dfc
Modified:
2 years ago
Reviewers:
CC:
minux, rsc, albert.strasheim, bsiegert, dsymonds, golang-dev
Visibility:
Public.

Description

runtime: add interface microbenchmarks

2011 Mac Mini, Core i5 @ 2.3Ghz

BenchmarkConvT2E        50000000                40.4 ns/op
BenchmarkConvT2EBig     20000000               107 ns/op
BenchmarkConvT2I        100000000               28.9 ns/op
BenchmarkConvI2E        500000000                5.93 ns/op
BenchmarkConvI2I        100000000               19.0 ns/op
BenchmarkAssertE2T      100000000               14.1 ns/op
BenchmarkAssertE2TBig   100000000               17.8 ns/op
BenchmarkAssertE2I      100000000               21.3 ns/op
BenchmarkAssertI2T      100000000               14.3 ns/op
BenchmarkAssertI2I      100000000               20.8 ns/op
BenchmarkAssertI2E      500000000                5.58 ns/op

Pandaboard, 2 x Omap4 @ 1.2Ghz

BenchmarkConvT2E        10000000               215 ns/op
BenchmarkConvT2EBig      1000000              3697 ns/op
BenchmarkConvT2I         5000000               666 ns/op
BenchmarkConvI2E        50000000                42.4 ns/op
BenchmarkConvI2I         5000000               489 ns/op
BenchmarkAssertE2T      20000000                90.0 ns/op
BenchmarkAssertE2TBig   20000000                91.6 ns/op
BenchmarkAssertE2I       5000000               515 ns/op
BenchmarkAssertI2T      20000000               124 ns/op
BenchmarkAssertI2I       5000000               517 ns/op
BenchmarkAssertI2E      50000000                47.2 ns/op
BenchmarkAssertE2E      50000000                42.7 ns/op

Patch Set 1 #

Patch Set 2 : diff -r 3355c03e3e2c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3355c03e3e2c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3355c03e3e2c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3355c03e3e2c https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 6 : diff -r 91a86970157c https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 91a86970157c https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 91a86970157c https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 91a86970157c https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r c8614af8523a https://go.googlecode.com/hg/ #

Patch Set 11 : diff -r 047d46024b74 https://go.googlecode.com/hg/ #

Patch Set 12 : diff -r 047d46024b74 https://go.googlecode.com/hg/ #

Patch Set 13 : diff -r 047d46024b74 https://go.googlecode.com/hg/ #

Patch Set 14 : diff -r 047d46024b74 https://go.googlecode.com/hg/ #

Patch Set 15 : diff -r 0051c7442fed https://go.googlecode.com/hg/ #

Patch Set 16 : diff -r 0051c7442fed https://go.googlecode.com/hg/ #

Patch Set 17 : diff -r 0051c7442fed https://go.googlecode.com/hg/ #

Patch Set 18 : diff -r 29d6152320be https://go.googlecode.com/hg/ #

Patch Set 19 : diff -r 29d6152320be https://go.googlecode.com/hg/ #

Patch Set 20 : diff -r 29d6152320be https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A src/pkg/runtime/iface_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 25
dfc
Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
2 years, 1 month ago #1
dfc
Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
2 years, 1 month ago #2
minux
lack BenchmarkAssertE2E? http://codereview.appspot.com/5777048/diff/6001/src/pkg/runtime/iface_test.go File src/pkg/runtime/iface_test.go (right): http://codereview.appspot.com/5777048/diff/6001/src/pkg/runtime/iface_test.go#newcode70 src/pkg/runtime/iface_test.go:70: func BenchmarkAssertI2E(b *testing.B) { This function doesn't ...
2 years, 1 month ago #3
dfc
On 2012/03/11 10:45:21, minux wrote: > lack BenchmarkAssertE2E? I couldn't figure out how to trigger ...
2 years, 1 month ago #4
dfc
Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
2 years, 1 month ago #5
minux
On 2012/03/11 10:55:49, dfc wrote: > On 2012/03/11 10:45:21, minux wrote: > > lack BenchmarkAssertE2E? ...
2 years, 1 month ago #6
dfc
Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
2 years, 1 month ago #7
rsc
This is great, but not now. It's not something that is important for Go 1, ...
2 years, 1 month ago #8
dfc
Understood. On 13/03/2012, at 3:31, Russ Cox <rsc@golang.org> wrote: > This is great, but not ...
2 years, 1 month ago #9
minux
Thus we have some more time to write the remaining BenchmarkAssertI2E? :-) On Tue, Mar ...
2 years, 1 month ago #10
dfc
Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
2 years, 1 month ago #11
dfc
Hello, this is the full set now. Leaving til after Go 1.
2 years, 1 month ago #12
minux
LGTM. Glad you've found the AssertI2E case. On Sat, Mar 17, 2012 at 5:31 PM, ...
2 years, 1 month ago #13
albert.strasheim
Took these for a spin for fun: Intel(R) Xeon(R) CPU X5675 @ 3.07GHz go test ...
2 years, 1 month ago #14
bsiegert
On Sat, Mar 17, 2012 at 12:20, <fullung@gmail.com> wrote: > BenchmarkConvT2I 2000000000 0.00 ns/op How ...
2 years, 1 month ago #15
dsymonds
On Mar 18, 2012 12:18 AM, "Benny Siegert" <bsiegert@gmail.com> wrote: > On Sat, Mar 17, ...
2 years, 1 month ago #16
rsc
On Sat, Mar 17, 2012 at 10:03, David Symonds <dsymonds@golang.org> wrote: >> On Sat, Mar ...
2 years ago #17
dfc
<ping /> For those interested, I have another CL, http://codereview.appspot.com/5798047/, which manually inlines the call ...
2 years ago #18
rsc
Please add copies of these with suffix 'Big' that use [2]*int{} as the value. Two ...
2 years ago #19
dfc
Wilco. On 10/04/2012, at 5:04, rsc@golang.org wrote: > Please add copies of these with suffix ...
2 years ago #20
dfc
Hi Russ, PTAL, I have added 2 cases of [2]*int{} where it made sense. Unscientific ...
2 years ago #21
dfc
Hello minux.ma@gmail.com, rsc@golang.org, fullung@gmail.com, bsiegert@gmail.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
2 years ago #22
rsc
LGTM Thank you. Please put a blank line between the copyright notice and the package ...
2 years ago #23
dfc
Done, and I've also freshened the sample output in the CL description.
2 years ago #24
dfc
2 years ago #25
*** Submitted as http://code.google.com/p/go/source/detail?r=a7ca1778740e ***

runtime: add interface microbenchmarks

2011 Mac Mini, Core i5 @ 2.3Ghz

BenchmarkConvT2E        50000000                40.4 ns/op
BenchmarkConvT2EBig     20000000               107 ns/op
BenchmarkConvT2I        100000000               28.9 ns/op
BenchmarkConvI2E        500000000                5.93 ns/op
BenchmarkConvI2I        100000000               19.0 ns/op
BenchmarkAssertE2T      100000000               14.1 ns/op
BenchmarkAssertE2TBig   100000000               17.8 ns/op
BenchmarkAssertE2I      100000000               21.3 ns/op
BenchmarkAssertI2T      100000000               14.3 ns/op
BenchmarkAssertI2I      100000000               20.8 ns/op
BenchmarkAssertI2E      500000000                5.58 ns/op

Pandaboard, 2 x Omap4 @ 1.2Ghz

BenchmarkConvT2E        10000000               215 ns/op
BenchmarkConvT2EBig      1000000              3697 ns/op
BenchmarkConvT2I         5000000               666 ns/op
BenchmarkConvI2E        50000000                42.4 ns/op
BenchmarkConvI2I         5000000               489 ns/op
BenchmarkAssertE2T      20000000                90.0 ns/op
BenchmarkAssertE2TBig   20000000                91.6 ns/op
BenchmarkAssertE2I       5000000               515 ns/op
BenchmarkAssertI2T      20000000               124 ns/op
BenchmarkAssertI2I       5000000               517 ns/op
BenchmarkAssertI2E      50000000                47.2 ns/op
BenchmarkAssertE2E      50000000                42.7 ns/op

R=minux.ma, rsc, fullung, bsiegert, dsymonds
CC=golang-dev
http://codereview.appspot.com/5777048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5