Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(790)

Issue 577520043: Issue 5773: Quarter Tones for all Languages incl. MusicXML import

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by Be-3
Modified:
4 months, 1 week ago
Reviewers:
antlists, dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5773: Quarter Tones for all Languages incl. MusicXML import modified: scm/define-note-names.scm - Missing quarter-tone definitions added, now all languages are complete. - Slightly changed sort order of norsk so that the commonly used forms (the ones with doulbe-s) are in front of the less common forms. - Proper language names consistently introduced (català and português added) modified: python/musicexp.py - Complete set of language-specific pitch conversions. - Order of lanuages corresponding to the "standard" LilyPond order. modified: scripts/musicxml2ly.py - Map input parameter -l (language) values to UTF-8 language names. modified: Documentation/changes.tely - Announce new language names - Announce complete set of quarter-tone definitions modified: Documentation/ca/notation/pitches.itely modified: Documentation/de/notation/pitches.itely modified: Documentation/es/notation/pitches.itely modified: Documentation/fr/notation/pitches.itely modified: Documentation/it/notation/pitches.itely modified: Documentation/ja/notation/pitches.itely modified: Documentation/notation/pitches.itely Notation 1.1.1 Writing pitches Note names in other languages - Tables unified and completed in all languages - Remarks about missing quarter-tone definitions removed

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+730 lines, -381 lines) Patch
M Documentation/ca/notation/pitches.itely View 4 chunks +60 lines, -48 lines 0 comments Download
M Documentation/changes.tely View 1 chunk +15 lines, -0 lines 0 comments Download
M Documentation/de/notation/pitches.itely View 4 chunks +63 lines, -45 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 4 chunks +61 lines, -48 lines 3 comments Download
M Documentation/fr/notation/pitches.itely View 4 chunks +60 lines, -48 lines 0 comments Download
M Documentation/it/notation/pitches.itely View 4 chunks +61 lines, -49 lines 0 comments Download
M Documentation/ja/notation/pitches.itely View 4 chunks +75 lines, -38 lines 0 comments Download
M Documentation/notation/pitches.itely View 5 chunks +32 lines, -20 lines 0 comments Download
M python/musicexp.py View 1 chunk +42 lines, -30 lines 1 comment Download
M scm/define-note-names.scm View 7 chunks +250 lines, -55 lines 1 comment Download
M scripts/musicxml2ly.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7
lemzwerg
LGTM, thanks! https://codereview.appspot.com/577520043/diff/555310043/python/musicexp.py File python/musicexp.py (left): https://codereview.appspot.com/577520043/diff/555310043/python/musicexp.py#oldcode365 python/musicexp.py:365: "nederlands": pitch_nederlands, You are sorting the entries ...
4 months, 3 weeks ago (2020-02-19 08:05:57 UTC) #1
Be-3
On 2020/02/19 08:05:57, lemzwerg wrote: > LGTM, thanks! > > https://codereview.appspot.com/577520043/diff/555310043/python/musicexp.py > File python/musicexp.py (left): ...
4 months, 2 weeks ago (2020-02-23 11:50:34 UTC) #2
antlists_youngman.org.uk
On 23/02/20 11:50, torsten.haemmerle@web.de wrote: > modified: scm/define-note-names.scm > - Missing quarter-tone definitions added, now ...
4 months, 1 week ago (2020-02-29 10:44:40 UTC) #3
Be-3
On 2020/02/29 10:44:40, antlists_youngman.org.uk wrote: > Smelling pistake, sorry ... - just spotted it. Hi ...
4 months, 1 week ago (2020-02-29 12:15:06 UTC) #4
dak
https://codereview.appspot.com/577520043/diff/555310043/Documentation/es/notation/pitches.itely File Documentation/es/notation/pitches.itely (right): https://codereview.appspot.com/577520043/diff/555310043/Documentation/es/notation/pitches.itely#newcode524 Documentation/es/notation/pitches.itely:524: @multitable {@w{@code{português} o}} {@code{do} @code{re}/@code{re} @code{mi} @code{fa} @code{sol} @code{la} ...
4 months, 1 week ago (2020-03-01 19:54:14 UTC) #5
Be-3
@multitable column entries are for spacing purposes only. In this case, they contain the exceptionally ...
4 months, 1 week ago (2020-03-01 21:56:33 UTC) #6
dak
4 months, 1 week ago (2020-03-01 22:20:49 UTC) #7
On 2020/03/01 21:56:33, Be-3 wrote:
> @multitable column entries are for spacing purposes only.  In this case, they
> contain the exceptionally long English names (independent of the document
> language).
> 
>
https://codereview.appspot.com/577520043/diff/555310043/Documentation/es/nota...
> File Documentation/es/notation/pitches.itely (right):
> 
>
https://codereview.appspot.com/577520043/diff/555310043/Documentation/es/nota...
> Documentation/es/notation/pitches.itely:558: @multitable {@w{@code{português}
> o}} {@code{s}/@code{-sharp}} {@code{f}/@code{-flat}}
> {@code{ss}/@code{x}/@code{-sharpsharp}} {@code{ff}/@code{-flatflat}}
> On 2020/03/01 19:54:14, dak wrote:
> > I am pretty sure that those aren't the Portuguese note names here.
> 
> No, definitely not.
> BUT (!) the @multitable line is just for column width spacing, thus mostly
> containing the column entry meant to determine the minimum column width.

Oh.  Sorry for the confusion, I'll go on with merging master into translations. 
This one tripped me up.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b