Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1746)

Issue 577110043: Issue 5605: implement original () with covariant return types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Dan Eble
Modified:
4 years, 5 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5605/ This is two separate commits: 1. the addition of original () to subclasses of Grob 2. the removal of unnecessary casts

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -22 lines) Patch
M lily/balloon.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/beam-quanting.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/item.hh View 1 chunk +5 lines, -0 lines 0 comments Download
M lily/include/paper-column.hh View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/include/spanner.hh View 1 chunk +5 lines, -0 lines 0 comments Download
M lily/include/system.hh View 1 chunk +5 lines, -0 lines 0 comments Download
M lily/item.cc View 1 chunk +1 line, -3 lines 0 comments Download
M lily/line-spanner.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/piano-pedal-bracket.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spacing-loose-columns.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spanner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/system.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M lily/tuplet-bracket.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/volta-bracket.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
4 years, 5 months ago (2019-11-16 21:48:50 UTC) #1
lemzwerg
4 years, 5 months ago (2019-11-16 22:39:01 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b