Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 5756065: code review 5756065: test: actually run them on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by brainman
Modified:
5 days, 21 hours ago
Reviewers:
rsc
CC:
golang-dev, r2, rsc, bradfitz, minux1
Visibility:
Public.

Description

test: actually run them on windows

Patch Set 1 #

Patch Set 2 : diff -r df3c38a88655 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r df3c38a88655 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c2433a6f3abe https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 90d7825be7c2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/run.bat View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
6 years, 9 months ago (2012-03-07 01:21:26 UTC) #1
brainman
This CL will break windows build, because of # test errorcheck import5.go : Multiple errors: ...
6 years, 9 months ago (2012-03-07 01:21:44 UTC) #2
r2
On Mar 7, 2012, at 12:21 PM, alex.brainman@gmail.com wrote: > This CL will break windows ...
6 years, 9 months ago (2012-03-07 01:44:08 UTC) #3
rsc
On Tue, Mar 6, 2012 at 20:21, <alex.brainman@gmail.com> wrote: > errorcheck import5.go : Multiple errors: ...
6 years, 9 months ago (2012-03-07 03:03:09 UTC) #4
bradfitz
On Tue, Mar 6, 2012 at 7:03 PM, Russ Cox <rsc@golang.org> wrote: > On Tue, ...
6 years, 9 months ago (2012-03-07 03:42:37 UTC) #5
brainman
Do we still want to fix this? Alex
6 years, 9 months ago (2012-03-09 01:32:55 UTC) #6
bradfitz
Oh, it's not? I woke up to a bunch of patches which made it look ...
6 years, 9 months ago (2012-03-09 01:36:01 UTC) #7
brainman
On 2012/03/09 01:36:01, bradfitz wrote: > Oh, it's not? ... > No, tests are still ...
6 years, 9 months ago (2012-03-09 01:42:22 UTC) #8
minux1
On Fri, Mar 9, 2012 at 9:42 AM, <alex.brainman@gmail.com> wrote: > No, tests are still ...
6 years, 9 months ago (2012-03-09 09:22:38 UTC) #9
rsc
LGTM but put the @echo off back. When this breaks the build, we can fix ...
6 years, 9 months ago (2012-03-09 19:25:58 UTC) #10
brainman
On 2012/03/09 19:25:58, rsc wrote: > LGTM but put the @echo off back. > Done. ...
6 years, 9 months ago (2012-03-09 23:01:10 UTC) #11
minux1
On 2012/03/09 23:01:10, brainman wrote: > Done. But now some tests break (I am using ...
6 years, 9 months ago (2012-03-12 06:04:16 UTC) #12
brainman
6 years, 9 months ago (2012-03-13 01:51:34 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=b78a69fcf693 ***

test: actually run them on windows

R=golang-dev, r, rsc, bradfitz, minux.ma
CC=golang-dev
http://codereview.appspot.com/5756065
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b