Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14163)

Issue 575320043: Issue 5609: prefer the instance method Paper_column::get_rank (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Dan Eble
Modified:
4 years, 4 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5609/ Prefer the instance method Paper_column::get_rank over the static method. The static method can eventually be eliminated, but not until some other cleaning is done. I have all the changes ready, but I plan to pace them to avoid review fatigue.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -42 lines) Patch
M lily/include/paper-column.hh View 1 chunk +11 lines, -1 line 0 comments Download
M lily/item.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/page-layout-problem.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/paper-column.cc View 2 chunks +1 line, -7 lines 0 comments Download
M lily/semi-tie.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spacing-determine-loose-columns.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M lily/spacing-loose-columns.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M lily/system.cc View 1 chunk +11 lines, -14 lines 0 comments Download
M lily/tie.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/tie-column.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
4 years, 5 months ago (2019-11-20 23:29:20 UTC) #1
lemzwerg
4 years, 5 months ago (2019-11-21 07:53:06 UTC) #2
From visual inspection: LGTM, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b