Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2389)

Issue 575260043: Issue 5595: Fix nonportable "echo -e" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Dan Eble
Modified:
4 years, 4 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5595/ "echo -e" is literally echoing "-e" in my Ubuntu 19.10 build environment. I've only changed the instances I was willing to test. "git grep" shows that there are a couple remaining.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M GNUmakefile.in View 1 chunk +5 lines, -1 line 0 comments Download
M make/lysdoc-targets.make View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
4 years, 4 months ago (2019-11-06 02:35:59 UTC) #1
lemzwerg
4 years, 4 months ago (2019-11-06 07:39:38 UTC) #2
LGTM, thanks.  In case there are problems, we might use `printf` instead, which
has less portability problems.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b