Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(981)

Issue 573770043: Use axis indexing to clarify different behaviors for X/Y skylines (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by hanwenn
Modified:
3 months, 1 week ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Use axis indexing to clarify different behaviors for X/Y skylines

Patch Set 1 #

Total comments: 2

Patch Set 2 : d'uh #

Patch Set 3 : against HEAD^ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M lily/stencil-integral.cc View 1 2 1 chunk +7 lines, -15 lines 0 comments Download

Messages

Total messages: 5
hahnjo
https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral.cc#newcode966 lily/stencil-integral.cc:966: copy.raise (y_pos[i] - my_y); hm, the old code passed ...
3 months, 1 week ago (2020-05-01 20:59:35 UTC) #1
hanwenn
https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral.cc#newcode966 lily/stencil-integral.cc:966: copy.raise (y_pos[i] - my_y); On 2020/05/01 20:59:35, hahnjo wrote: ...
3 months, 1 week ago (2020-05-01 22:20:34 UTC) #2
hanwenn
d'uh
3 months, 1 week ago (2020-05-01 22:26:53 UTC) #3
hanwenn
against HEAD^
3 months, 1 week ago (2020-05-01 22:27:39 UTC) #4
hahnjo
3 months, 1 week ago (2020-05-02 07:41:47 UTC) #5
LGTM (provided there are no regtest differences)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b