Use axis indexing to clarify different behaviors for X/Y skylines

Use axis indexing to clarify different behaviors for X/Y skylines

[hahnjo, 2020-05-01 20:59:35]

https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):

https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral...
lily/stencil-integral.cc:966: copy.raise (y_pos[i] - my_y);
hm, the old code passed different arguments in the two branches:
copy.shift (x_pos[i] - my_x);
vs.
copy.shift (y_pos[i] - my_y);

and
copy.raise (y_pos[i] - my_y);
vs.
copy.raise (x_pos[i] - my_x);

AFAICS this has nothing to do with commutativity of shift and raise.

[hanwenn, 2020-05-01 22:20:34]

https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):

https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral...
lily/stencil-integral.cc:966: copy.raise (y_pos[i] - my_y);
On 2020/05/01 20:59:35, hahnjo wrote:
> hm, the old code passed different arguments in the two branches:
> copy.shift (x_pos[i] - my_x);
> vs.
> copy.shift (y_pos[i] - my_y);
> 
> and
> copy.raise (y_pos[i] - my_y);
> vs.
> copy.raise (x_pos[i] - my_x);
> 
> AFAICS this has nothing to do with commutativity of shift and raise.

Ah, you are right. Silly me.

[hanwenn, 2020-05-01 22:26:53]

d'uh

[hanwenn, 2020-05-01 22:27:39]

against HEAD^

[hahnjo, 2020-05-02 07:41:47]

LGTM (provided there are no regtest differences)