Issue #1204: fix font-name-add-files regtest

Issue #1204: fix font-name-add-files regtest

The temporary directory might not be empty if some
versions of fontconfig add a .uuid file inside it.

[dak, 2020-04-20 12:05:15]

https://codereview.appspot.com/573730044/diff/583810043/input/regression/font...
File input/regression/font-name-add-files.ly (right):

https://codereview.appspot.com/573730044/diff/583810043/input/regression/font...
input/regression/font-name-add-files.ly:25: tmpdir = #(let ((env-tmpdir (getenv
"TMPDIR")))
tmpdir = #(or (getenv "TMPDIR") "/tmp")

https://codereview.appspot.com/573730044/diff/583810043/input/regression/font...
input/regression/font-name-add-files.ly:28: dummyname = #(port-filename
(mkstemp! (string-append tmpdir "/" "dummyfont-XXXXXX")))
This fixes the problem that mkstemp! needs a writable string since string-append
returns a newly allocated string.  Whether it's by design or not the computer
won't care, so that should fix the potential Guile-2.x problem.

https://codereview.appspot.com/573730044/diff/583810043/input/regression/font...
input/regression/font-name-add-files.ly:252: (if (or (equal? "." f)
No point in a functional language to write as if expressions and procedures were
different things.  Just write

(or (equal? "." f) (equal? ".." f)
    (delete-file (string-append ...)))

[Valentin Villenave, 2020-04-20 13:36:57]

On 2020/04/20 12:05:15, dak wrote:
>
https://codereview.appspot.com/573730044/diff/583810043/input/regression/font...
> File input/regression/font-name-add-files.ly (right):
> 
>
https://codereview.appspot.com/573730044/diff/583810043/input/regression/font...
> input/regression/font-name-add-files.ly:25: tmpdir = #(let ((env-tmpdir
(getenv
> "TMPDIR")))
> tmpdir = #(or (getenv "TMPDIR") "/tmp")

Indeed. This should have occurred to me (unlike the similar one below).

>
https://codereview.appspot.com/573730044/diff/583810043/input/regression/font...
> input/regression/font-name-add-files.ly:28: dummyname = #(port-filename
> (mkstemp! (string-append tmpdir "/" "dummyfont-XXXXXX")))
> This fixes the problem that mkstemp! needs a writable string since
string-append
> returns a newly allocated string.*

Yes, thus eliminating the need for string-copy and such.

>
https://codereview.appspot.com/573730044/diff/583810043/input/regression/font...
> input/regression/font-name-add-files.ly:252: (if (or (equal? "." f)
> No point in a functional language to write as if expressions and procedures
were
> different things.  Just write
> 
> (or (equal? "." f) (equal? ".." f)
>     (delete-file (string-append ...)))

Heh. I actually lifted that part verbatim from framework-ps.scm. That's a nice,
concise and elegant syntax, it wouldn't have occurred to me. Thanks!

V.

[Valentin Villenave, 2020-04-20 21:15:53]

More concise (or ...) syntax for conditional switch