Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4817)

Issue 573270043: Avoid easy warnings with Clang

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by hahnjo
Modified:
1 week, 5 days ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Avoid easy warnings with Clang Building with Clang is currently a lot nosier than with GCC. This represents a first step into the right direction by picking the low-hanging fruits. 1. Fix warning flag detection for Clang Clang requires -Werror=unknown-warning-option to actually throw an error if it doesn't know about a warning flag. 2. Fix struct vs. class template for PQueue Clang issues a warning that this could be an issue for the "Windows C++ ABI". Apparently, that's not really causing problems as the mismatch was introduced by commit c8989177a in 1997...

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment #

Patch Set 3 : Add comment about GCC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M configure.ac View 1 2 2 chunks +17 lines, -2 lines 0 comments Download
M flower/include/flower-proto.hh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
lemzwerg
LGTM https://codereview.appspot.com/573270043/diff/549210045/configure.ac File configure.ac (right): https://codereview.appspot.com/573270043/diff/549210045/configure.ac#newcode212 configure.ac:212: # options. Unfortunately GCC doesn't support this options, ...
2 weeks, 3 days ago (2019-11-19 22:13:40 UTC) #1
hahnjo
Fix comment
2 weeks, 3 days ago (2019-11-20 12:28:00 UTC) #2
lemzwerg
Please extend this patch to cover gcc, too.
1 week, 6 days ago (2019-11-24 15:13:56 UTC) #3
hahnjo
On 2019/11/24 15:13:56, lemzwerg wrote: > Please extend this patch to cover gcc, too. AFAICT ...
1 week, 6 days ago (2019-11-24 17:15:45 UTC) #4
lemzwerg
> AFAICT this already works with GCC because it just > returns an error code: ...
1 week, 6 days ago (2019-11-24 17:24:07 UTC) #5
hahnjo
On 2019/11/24 17:24:07, lemzwerg wrote: > > AFAICT this already works with GCC because it ...
1 week, 6 days ago (2019-11-24 17:27:06 UTC) #6
hahnjo
1 week, 5 days ago (2019-11-25 17:34:31 UTC) #7
Add comment about GCC
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b