Issue 572040043: Use vectors rather than lists for skylines.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 572040043: Use vectors rather than lists for skylines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 12 months ago by hanwenn

Modified:
3 years, 12 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Use vectors rather than lists for skylines. Linked lists have poor locality. This yields a 5.5% speedup on the Carver MDSM score. Raw timings (-O2 -pg build, CPU underclocked to 2Ghz): Arrays: 67.64 67.23 66.96 Lists: 70.89 70.91 71.09

Patch Set 1 #

Patch Set 2 : jonas #

Created: 3 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -79 lines)			Patch
	M	lily/include/skyline.hh	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	lily/skyline.cc	View	1	25 chunks	+86 lines, -74 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mixup, sorry.

Expand All Messages | Collapse All Messages