Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(788)

Issue 5715053: Fix crash when unknown grob name is passed to ly:engraver-make-grob

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by Pavel Roskin
Modified:
1 month, 2 weeks ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Fix crash when unknown grob name is passed to ly:engraver-make-grob

Patch Set 1 #

Patch Set 2 : Added throwing an exception #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M lily/engraver.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M lily/engraver-scheme.cc View 1 chunk +7 lines, -1 line 1 comment Download

Messages

Total messages: 9
Pavel Roskin
I've seen it many times that Lilypond would crash during my experiments with Scheme code. ...
8 years, 1 month ago (2012-03-01 23:02:57 UTC) #1
dak
On 2012/03/01 23:02:57, Pavel Roskin wrote: > I've seen it many times that Lilypond would ...
8 years, 1 month ago (2012-03-01 23:35:30 UTC) #2
Pavel Roskin
There are only two calls to scm_throw in Lilypond, and I could not find out ...
8 years, 1 month ago (2012-03-03 01:22:30 UTC) #3
hanwenn
On Fri, Mar 2, 2012 at 10:22 PM, <plroskin@gmail.com> wrote: > There are only two ...
8 years, 1 month ago (2012-03-03 04:17:45 UTC) #4
Pavel Roskin
I'm not getting any interesting information: ... [/usr/local/share/lilypond/2.15.32/ly/context-mods-init.ly] [/usr/local/share/lilypond/2.15.32/ly/engraver-init.ly]] [bad.ly] Interpreting music... [/usr/local/share/lilypond/2.15.32/fonts/otf/emmentaler-20.otf] fatal error: ...
8 years, 1 month ago (2012-03-03 04:38:36 UTC) #5
dak
On 2012/03/03 04:38:36, Pavel Roskin wrote: > I'm not getting any interesting information: > > ...
8 years, 1 month ago (2012-03-03 05:43:50 UTC) #6
dak
http://codereview.appspot.com/5715053/diff/2001/lily/engraver-scheme.cc File lily/engraver-scheme.cc (right): http://codereview.appspot.com/5715053/diff/2001/lily/engraver-scheme.cc#newcode42 lily/engraver-scheme.cc:42: programming_error ("cannot create grob"); This gives no helpful indication ...
8 years ago (2012-03-20 23:29:55 UTC) #7
hanwenn
1 month, 3 weeks ago (2020-02-15 17:10:46 UTC) #8
Pavel Roskin
1 month, 2 weeks ago (2020-02-20 06:27:37 UTC) #9
Thanks for the ping, it's been a long time! Sadly, I haven't used lilypond for
years. I tried to update my patch, but I cannot spend too much time on it.
I see that my change to engraver.cc is no longer needed, as there is a check
there that was missing back at the time. The change to engraver-scheme.cc still
applies, but I see that the comments here indicate that it's incomplete and
doesn't provide much value.
I have no recollection what I was doing with ly:engraver-make-grob, so I googled
to that symbol and found an implementation of ambitus at
http://lilypond.org/doc/v2.19/Documentation/snippets/contexts-and-engravers
I replaced "Ambitus" with "Ambituus" and I see the check added in engraver.cc
being triggered ("programming error: No grob definition found for `Ambituus’")
but the segfault happens not in ly_engraver_make_grob but in
Item::spanned_rank_interval.
So I think this patch is irrelevant and can be discarded.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b