Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(957)

Issue 570540043: Add warning message for unknown code in fret-diagram-verbose

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Carl
Modified:
5 years, 1 month ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add warning message for unknown code in fret-diagram-verbose This patch does not change the printed or midi output; it only generates a warning on the console and in the logfile. Because there is no change to the printed output, I felt like there was no need for a regression test. You can see the effect of this patch by running the following code: \version "2.19.82" { s1^\markup{ \fret-diagram-verbose #'( (please harakiri 1 5) ) } } which will create a blank fret diagram and print a warning message in the log.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Respond to Harm's suggestion #

Patch Set 3 : Testing git-cl upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M scm/fret-diagrams.scm View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
thomasmorley651
https://codereview.appspot.com/570540043/diff/548530043/scm/fret-diagrams.scm File scm/fret-diagrams.scm (right): https://codereview.appspot.com/570540043/diff/548530043/scm/fret-diagrams.scm#newcode267 scm/fret-diagrams.scm:267: (symbol->string my-code)))) symbol->string relies on my-code being a symbol. ...
5 years, 1 month ago (2019-03-16 08:34:41 UTC) #1
Carl
Respond to Harm's suggestion
5 years, 1 month ago (2019-03-17 23:34:46 UTC) #2
Carl
5 years, 1 month ago (2019-03-17 23:46:46 UTC) #3
Testing git-cl upload
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b