Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 5698043: code review 5698043: weekly.2012-02-22 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by adg
Modified:
9 years, 2 months ago
Reviewers:
CC:
golang-dev, r, bradfitzgoog
Visibility:
Public.

Description

weekly.2012-02-22

Patch Set 1 #

Total comments: 10

Patch Set 2 : diff -r 71e709c69318 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 71e709c69318 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 116b2ccf6c88 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1 line) Patch
M .hgtags View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 7
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
9 years, 2 months ago (2012-02-23 05:05:35 UTC) #1
r
http://codereview.appspot.com/5698043/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5698043/diff/1/doc/devel/weekly.html#newcode17 doc/devel/weekly.html:17: <h2 id="2012-02-22">2012-02-22</h2> might want to say we hope that ...
9 years, 2 months ago (2012-02-23 05:23:47 UTC) #2
adg
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 2 months ago (2012-02-23 05:29:43 UTC) #3
bradfitzgoog
http://codereview.appspot.com/5698043/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5698043/diff/1/doc/devel/weekly.html#newcode32 doc/devel/weekly.html:32: The Process.Wait method has dropped its option argument and ...
9 years, 2 months ago (2012-02-23 05:30:25 UTC) #4
adg
http://codereview.appspot.com/5698043/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5698043/diff/1/doc/devel/weekly.html#newcode17 doc/devel/weekly.html:17: <h2 id="2012-02-22">2012-02-22</h2> On 2012/02/23 05:23:47, r wrote: > might ...
9 years, 2 months ago (2012-02-23 05:34:47 UTC) #5
r
LGTM
9 years, 2 months ago (2012-02-23 05:38:23 UTC) #6
adg
9 years, 2 months ago (2012-02-23 05:40:19 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=96bd78e7d35e ***

weekly.2012-02-22

R=golang-dev, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5698043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b