Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(899)

Issue 56980043: code review 56980043: syscall: add support for FreeBSD 10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by mikio
Modified:
6 years, 10 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, rsc, minux1, iant
Visibility:
Public.

Description

syscall: add support for FreeBSD 10 This CL tweaks syscall.InterfaceMessage to support FreeBSD 10 and prior to 10. See http://svnweb.freebsd.org/base?view=revision&revision=254804. Fixes issue 7193.

Patch Set 1 : diff -r abd51e52924a https://code.google.com/p/go #

Patch Set 2 : diff -r c12c08ac4dc7 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M src/pkg/syscall/route_freebsd.go View 1 chunk +8 lines, -2 lines 0 comments Download
A src/pkg/syscall/route_freebsd_32bit.go View 1 chunk +24 lines, -0 lines 0 comments Download
A src/pkg/syscall/route_freebsd_64bit.go View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 10 months ago (2014-02-26 06:55:15 UTC) #1
mikio
Hello golang-codereviews@googlegroups.com, rsc@golang.org, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 10 months ago (2014-02-27 15:48:11 UTC) #2
gobot
R=iant@golang.org (assigned by mikioh.mikioh@gmail.com)
6 years, 10 months ago (2014-03-01 01:24:55 UTC) #3
iant
LGTM
6 years, 10 months ago (2014-03-01 19:41:22 UTC) #4
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=1a72d2295c21 *** syscall: add support for FreeBSD 10 This CL tweaks syscall.InterfaceMessage ...
6 years, 10 months ago (2014-03-04 00:27:01 UTC) #5
gobot
6 years, 10 months ago (2014-03-04 03:03:09 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the windows-386-ec2 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b