Fix output-distance tests

Fix output-distance tests

* Call /bin/bash explicitly in system().

* Hide output in case of success with run-and-check

* In case of failure, run-and-check tails the log file.

* Run output-distance as part of default build.

Tested:
  Ubuntu Xenial in-tree make, make check.

[hanwenn, 2020-03-14 20:13:39]

srcdir

[lemzwerg, 2020-03-14 21:58:52]

Just skimming the code: LGTM

https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
File scripts/build/output-distance.py (right):

https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
scripts/build/output-distance.py:66: # explicitly use bash, so we don't get dash
on Ubuntu.
This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now, AFAICS,
`bash` is optional, and `configure` falls back to whatever is given in the
`SHELL` environment variable.

[hanwenn, 2020-03-15 15:12:42]

On 2020/03/14 21:58:52, lemzwerg wrote:
> Just skimming the code: LGTM
> 
>
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
> File scripts/build/output-distance.py (right):
> 
>
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
> scripts/build/output-distance.py:66: # explicitly use bash, so we don't get
dash
> on Ubuntu.
> This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now, AFAICS,
> `bash` is optional, and `configure` falls back to whatever is given in the
> `SHELL` environment variable.

Are there still systems that run without bash that we care about?

I created http://codereview.appspot.com/579480047 for looking more closely at
how we configure shell.

[lemzwerg, 2020-03-15 15:42:44]

> Are there still systems that run without bash that we care about?

I guess all BSD variants might miss bash since it is evil, evil GNU software.

[dak, 2020-03-15 16:10:44]

hanwenn@gmail.com writes:

> On 2020/03/14 21:58:52, lemzwerg wrote:
>> Just skimming the code: LGTM
>> 
>>
>
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
>> File scripts/build/output-distance.py (right):
>> 
>>
>
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
>> scripts/build/output-distance.py:66: # explicitly use bash, so we
> don't get dash
>> on Ubuntu.
>> This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now,
> AFAICS,
>> `bash` is optional, and `configure` falls back to whatever is given in
> the
>> `SHELL` environment variable.
>
> Are there still systems that run without bash that we care about?

MacOSX, FreeBSD?

-- 
David Kastrup

[hanwenn, 2020-03-15 16:13:59]

On Sun, Mar 15, 2020 at 5:10 PM David Kastrup <dak@gnu.org> wrote:
>
> hanwenn@gmail.com writes:
>
> > On 2020/03/14 21:58:52, lemzwerg wrote:
> >> Just skimming the code: LGTM
> >>
> >>
> >
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
> >> File scripts/build/output-distance.py (right):
> >>
> >>
> >
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
> >> scripts/build/output-distance.py:66: # explicitly use bash, so we
> > don't get dash
> >> on Ubuntu.
> >> This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now,
> > AFAICS,
> >> `bash` is optional, and `configure` falls back to whatever is given in
> > the
> >> `SHELL` environment variable.
> >
> > Are there still systems that run without bash that we care about?
>
> MacOSX, FreeBSD?

But for compiling LilyPond you'll need to install a significant set of
dependencies (tex, metafont, bison, flex etc.). I think it is
reasonable for us to require bash as well.

also,
https://www.golem.de/news/apple-macos-wechselt-von-bash-auf-zsh-als-standard-...
suggests that OSX actually uses bash.

--
Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen

[dak, 2020-03-15 16:21:33]

Han-Wen Nienhuys <hanwenn@gmail.com> writes:

> On Sun, Mar 15, 2020 at 5:10 PM David Kastrup <dak@gnu.org> wrote:
>>
>> hanwenn@gmail.com writes:
>>
>> > On 2020/03/14 21:58:52, lemzwerg wrote:
>> >> Just skimming the code: LGTM
>> >>
>> >>
>> >
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
>> >> File scripts/build/output-distance.py (right):
>> >>
>> >>
>> >
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-...
>> >> scripts/build/output-distance.py:66: # explicitly use bash, so we
>> > don't get dash
>> >> on Ubuntu.
>> >> This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now,
>> > AFAICS,
>> >> `bash` is optional, and `configure` falls back to whatever is given in
>> > the
>> >> `SHELL` environment variable.
>> >
>> > Are there still systems that run without bash that we care about?
>>
>> MacOSX, FreeBSD?
>
> But for compiling LilyPond you'll need to install a significant set of
> dependencies (tex, metafont, bison, flex etc.). I think it is
> reasonable for us to require bash as well.
>
> also,
>
https://www.golem.de/news/apple-macos-wechselt-von-bash-auf-zsh-als-standard-...
> suggests that OSX actually uses bash.

Paywalled site.

Anyway, it is well-known that Apple does not use anything under GPLv3,
so if at all, they are using/offering a severely outdated version.

-- 
David Kastrup

[dan_faithful.be, 2020-03-15 17:29:20]

On Mar 15, 2020, at 12:21, David Kastrup <dak@gnu.org> wrote:
> 
> Han-Wen Nienhuys <hanwenn@gmail.com> writes:
>> suggests that OSX actually uses bash.
> 
> Paywalled site.

The current macOS (10.15.3, "Catalina") sets zsh as the default shell for new
users.  bash is still provided.

    $ zsh --version
    zsh 5.7.1 (x86_64-apple-darwin19.0)
    $ /bin/sh --version
    GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)
    Copyright (C) 2007 Free Software Foundation, Inc.
— 
Dan

[hanwenn, 2020-03-21 23:02:02]

commit fd4021a3725cda2fe41079af8208a629dda39f1a
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Sat Mar 14 00:01:03 2020 +0100

    Fix output-distance tests