Changes to ICMPv6 (and minor fixes)

The patch is all about proper ICMPv6 behavior.
1) UDP sockets must be able to set the ICMP callback also for ICMPv6
2) ICMPv6 should honor this
3) The ICMPv6 post-fragmentation-loss was wrong
4) minor stuff like a couple missing virtual declarations

I still have to double check the error ICMPv6 length, as right now it's too short. Not raising bugs, but it's not exactly the RFC behavior.

[Tommaso Pecorella, 2012-02-20 14:09:34]

Hi,

this patch fixes some stuff in ICMPv6 that was never actually used, since there
was no support for L4 in IPv6. Now we do have it tho :)

T.

[Tom Henderson, 2012-02-25 16:33:17]

looks good, just some minor nits (inline).

I noticed various small style issues (space before parentheses); suggest to run
these files through check-style.py  (at least to level 1, preferably to level
3).

http://codereview.appspot.com/5689049/diff/13/src/internet/model/tcp-socket-b...
File src/internet/model/tcp-socket-base.cc (right):

http://codereview.appspot.com/5689049/diff/13/src/internet/model/tcp-socket-b...
src/internet/model/tcp-socket-base.cc:264: NS_LOG_FUNCTION_NOARGS ();
This log message is intended for static functions.  Please use NS_LOG_FUNCTION
(this) for member methods containing no arguments.

http://codereview.appspot.com/5689049/diff/13/src/internet/test/ipv6-fragment...
File src/internet/test/ipv6-fragmentation-test.cc (right):

http://codereview.appspot.com/5689049/diff/13/src/internet/test/ipv6-fragment...
src/internet/test/ipv6-fragmentation-test.cc:21: * This is the test code for
ipv4-l3protocol.cc (only the fragmentation and reassembly part).
revise comment for Ipv6?

http://codereview.appspot.com/5689049/diff/13/src/internet/test/ipv6-fragment...
src/internet/test/ipv6-fragmentation-test.cc:164: //         
udpSocket->MulticastJoinGroup (0, Ipv6Address ("10.0.0.1"));
delete?

[Tommaso Pecorella, 2012-02-25 17:42:09]

On 2012/02/25 17:36:21, Tommaso Pecorella wrote:

I used check-style.py -l3 on all the involved files (both headers and sources).
Some changes are, thus purely cosmetic.

Cheers,

T.