Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(156)

Issue 5683054: code review 5683054: misc/dist/windows: fix broken icon, other misc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Joe Poirier
Modified:
2 years, 1 month ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

misc/dist/windows: fix broken icon, other misc

fix, and shrink, the gopher icon, txt extensions
for license and readme files, minor format changes
in the wxs file

Patch Set 1 #

Patch Set 2 : diff -r fc27ee3503c3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fc27ee3503c3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r eb269c0c7624 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r eb269c0c7624 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 5d3f04419f11 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M misc/dist/windows/LICENSE.rtf View 1 2 3 Binary file 0 comments Download
M misc/dist/windows/README.txt View 1 2 3 4 1 chunk +3 lines, -5 lines 0 comments Download
M misc/dist/windows/images/gopher.ico View 1 Binary file 0 comments Download
M misc/dist/windows/installer.wxs View 1 2 3 4 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 5
Joe Poirier
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
2 years, 1 month ago #1
rsc
LGTM
2 years, 1 month ago #2
rsc
Is it possible to name the files .rtf instead of .txt? They're not exactly text.
2 years, 1 month ago #3
Joe Poirier
On Tue, Feb 21, 2012 at 12:34 PM, Russ Cox <rsc@golang.org> wrote: > Is it ...
2 years, 1 month ago #4
Joe Poirier
2 years, 1 month ago #5
*** Submitted as http://code.google.com/p/go/source/detail?r=aa3eeba028bf ***

misc/dist/windows: fix broken icon, other misc

fix, and shrink, the gopher icon, txt extensions
for license and readme files, minor format changes
in the wxs file

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5683054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1274:9b9295c7fd64