Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(873)

Issue 56770044: code review 56770044: syscall: regenerate z-files on FreeBSD 10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by mikio
Modified:
6 years, 10 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, rsc, minux1, iant
Visibility:
Public.

Description

syscall: regenerate z-files on FreeBSD 10 Unfortunately FreeBSD 10 has changed its syscall arguments for some reasons but as per request at golang-dev this CL does not generate some structures, syscall numbers and constants as compatible to FreeBSD 10 as follows: Structure: Stat_t, IfData, IfMsghdr are based on 8-STABLE Syscall number: Capsicum API is based on 9-STABLE Constant: IFT_CARP, SIOCAIFADDR, SIOCSIFPHYADDR are based on 9-STABLE Update issue 7193 FreeBSD 10 breaking changes: r205792: Rename st_*timespec fields to st_*tim for POSIX 2008 compliance. http://svnweb.freebsd.org/base?view=revision&revision=205792 r254804: Restructure the mbuf pkthdr to make it fit for upcoming capabilities and features. http://svnweb.freebsd.org/base?view=revision&revision=254804 r255219: Change the cap_rights_t type from uint64_t to a structure that we can extend in the future in a backward compatible (API and ABI) way. http://svnweb.freebsd.org/base?view=revision&revision=255219

Patch Set 1 : diff -r abd51e52924a https://code.google.com/p/go #

Patch Set 2 : diff -r d99a2e24dd10 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -93 lines) Patch
M src/pkg/syscall/mkall.sh View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/syscall/mkerrors.sh View 2 chunks +9 lines, -0 lines 0 comments Download
M src/pkg/syscall/mksysnum_freebsd.pl View 1 chunk +13 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_freebsd.go View 5 chunks +96 lines, -9 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_386.go View 20 chunks +30 lines, -3 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_amd64.go View 20 chunks +31 lines, -3 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_arm.go View 19 chunks +27 lines, -8 lines 0 comments Download
M src/pkg/syscall/zsysnum_freebsd_386.go View 5 chunks +13 lines, -7 lines 0 comments Download
M src/pkg/syscall/zsysnum_freebsd_amd64.go View 5 chunks +13 lines, -7 lines 0 comments Download
M src/pkg/syscall/zsysnum_freebsd_arm.go View 6 chunks +14 lines, -13 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_386.go View 4 chunks +41 lines, -4 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_amd64.go View 4 chunks +41 lines, -4 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_arm.go View 13 chunks +78 lines, -32 lines 0 comments Download

Messages

Total messages: 9
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 10 months ago (2014-02-26 06:53:15 UTC) #1
mikio
Hello golang-codereviews@googlegroups.com, rsc@golang.org, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 10 months ago (2014-02-27 15:44:52 UTC) #2
gobot
R=minux.ma@gmail.com (assigned by mikioh.mikioh@gmail.com)
6 years, 10 months ago (2014-03-01 01:25:41 UTC) #3
gobot
R=minux.ma@gmail.com (assigned by mikioh.mikioh@gmail.com)
6 years, 10 months ago (2014-03-01 01:25:55 UTC) #4
gobot
R=rsc@golang.org (assigned by mikioh.mikioh@gmail.com)
6 years, 10 months ago (2014-03-01 01:26:03 UTC) #5
mikio
gobot says "ERROR: unknown reviewer", hm...
6 years, 10 months ago (2014-03-01 01:26:58 UTC) #6
iant
LGTM
6 years, 10 months ago (2014-03-01 19:30:50 UTC) #7
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=a3b2bc0b515e *** syscall: regenerate z-files on FreeBSD 10 Unfortunately FreeBSD 10 has ...
6 years, 10 months ago (2014-03-04 00:26:06 UTC) #8
gobot
6 years, 10 months ago (2014-03-04 02:25:10 UTC) #9
Message was sent while issue was closed.
This CL appears to have broken the netbsd-386-minux builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b