Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 567530052: output-distance: create PNG files in batch (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by hanwenn
Modified:
4 weeks, 1 day ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

output-distance: create PNG files in batch

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M scripts/build/output-distance.py View 1 chunk +26 lines, -23 lines 2 comments Download

Messages

Total messages: 2
hahnjo
https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-distance.py#newcode739 scripts/build/output-distance.py:739: ' -sDEVICE=png16m' you might want to remove this and ...
1 month ago (2020-05-02 15:07:20 UTC) #1
hanwenn
1 month ago (2020-05-02 21:47:49 UTC) #2
https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-...
File scripts/build/output-distance.py (right):

https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-...
scripts/build/output-distance.py:739: ' -sDEVICE=png16m'
On 2020/05/02 15:07:20, hahnjo wrote:
> you might want to remove this and instead use -dNODISPLAY; interesting that
> png16m doesn't force you to specify an output file, pdfwrite does...
> 
> and I'd reorder the invocation to have the "generic" options -q -dNOPAUSE
> -dNOSAFER -dEPSCrop at the beginning; IMHO this makes it much easier to reason
> about the invocation

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b