Issue 567530052: output-distance: create PNG files in batch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 567530052: output-distance: create PNG files in batch (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 11 months ago by hanwenn

Modified:
3 years, 11 months ago

Reviewers:
hahnjo

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

output-distance: create PNG files in batch

Patch Set 1 #

Total comments: 2

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -23 lines)			Patch
	M	scripts/build/output-distance.py	View		1 chunk	+26 lines, -23 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hahnjo

https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-distance.py#newcode739 scripts/build/output-distance.py:739: ' -sDEVICE=png16m' you might want to remove this and ...

3 years, 11 months ago (2020-05-02 15:07:20 UTC) #1

hanwenn

3 years, 11 months ago (2020-05-02 21:47:49 UTC) #2

https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-...
File scripts/build/output-distance.py (right):

https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-...
scripts/build/output-distance.py:739: ' -sDEVICE=png16m'
On 2020/05/02 15:07:20, hahnjo wrote:
> you might want to remove this and instead use -dNODISPLAY; interesting that
> png16m doesn't force you to specify an output file, pdfwrite does...
> 
> and I'd reorder the invocation to have the "generic" options -q -dNOPAUSE
> -dNOSAFER -dEPSCrop at the beginning; IMHO this makes it much easier to reason
> about the invocation

Done.

Expand All Messages | Collapse All Messages