Issue 5674051: state: add some more informative error messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5674051: state: add some more informative error messages

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rog

Modified:
12 years, 2 months ago

Reviewers:
mp+93153, niemeyer, fwereade

Visibility:
Public.

Description

It's only a start. https://code.launchpad.net/~rogpeppe/juju/state-add-errors/+merge/93153 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -22 lines)			Patch
	M	state/open.go	View		1 chunk	+3 lines, -2 lines	1 comment	Download
	M	state/state.go	View		1 chunk	+17 lines, -20 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

12 years, 2 months ago (2012-02-16 18:41:36 UTC) #3

https://codereview.appspot.com/5674051/diff/1/state/open.go
File state/open.go (right):

https://codereview.appspot.com/5674051/diff/1/state/open.go#newcode32
state/open.go:32: return nil, fmt.Errorf("zookeeper dial %q failed: %v", addrs,
err)
Let's please fix this in gozk instead. There's no information being added here
that can't be done there.

https://codereview.appspot.com/5674051/diff/1/state/state.go
File state/state.go (right):

https://codereview.appspot.com/5674051/diff/1/state/state.go#newcode148
state/state.go:148: return fmt.Errorf("cannot check existence of /initialized:
%v", err)
Ditto.

https://codereview.appspot.com/5674051/diff/1/state/state.go#newcode160
state/state.go:160: err = fmt.Errorf("cannot create %s: %v", name, err)
Ditto.

Expand All Messages | Collapse All Messages