Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2073)

Issue 5673051: Purge queued hooks upon a hook error.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Jim Baker
Modified:
9 years, 3 months ago
Reviewers:
mp+93135
Visibility:
Public.

Description

Implements changes necessary to purge queued hooks. This involves two set of changes: 1) not executing a -changed hook if the -joined hook fails, which is the senario seen in the related bug (and exactly tested by test_purge_queued_hook_after error); 2) purging changes from the scheduler in the event of an errored hook, until the workflow is reset (remaining tests). There are also some minor fixes of related docstrings, removal of unnecessary sleeps, and adding a missing yield (in releasing the run lock for UnitRelationLifecycle.start). https://code.launchpad.net/~jimbaker/juju/purge-queued-hooks/+merge/93135 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -54 lines) Patch
M juju/hooks/scheduler.py View 6 chunks +67 lines, -16 lines 0 comments Download
M juju/hooks/tests/test_scheduler.py View 5 chunks +65 lines, -10 lines 0 comments Download
M juju/unit/lifecycle.py View 4 chunks +31 lines, -6 lines 0 comments Download
M juju/unit/tests/test_lifecycle.py View 4 chunks +35 lines, -16 lines 0 comments Download
M juju/unit/tests/test_workflow.py View 5 chunks +132 lines, -6 lines 0 comments Download
M juju/unit/workflow.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
Jim Baker
12 years, 1 month ago (2012-02-15 05:07:30 UTC) #1
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b