Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2545)

Issue 56670043: Add networks attribute to RunServer params

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by gz
Modified:
10 years, 2 months ago
Reviewers:
dimitern, mp+203113, natefinch
Visibility:
Public.

Description

Add networks attribute to RunServer params This enables the starting of a server on a specific network, which is required for some situations where multiple networks exist. This is not well tested at present, to do a proper job some more network related operations need to be added so the tests can do real operations. https://code.launchpad.net/~gz/goose/run_server_networks/+merge/203113 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M nova/nova.go View 2 chunks +10 lines, -0 lines 0 comments Download
M testservices/novaservice/service_http.go View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4
gz
Please take a look.
10 years, 2 months ago (2014-01-24 16:41:10 UTC) #1
natefinch
LGTM
10 years, 2 months ago (2014-01-24 16:49:04 UTC) #2
dimitern
In the future, please make sure you've updated the dependencies.tsv file when making changes that ...
10 years, 2 months ago (2014-01-27 01:02:57 UTC) #3
gz
10 years, 2 months ago (2014-01-27 07:31:56 UTC) #4
On 2014/01/27 01:02:57, dimitern wrote:
> In the future, please make sure you've updated the dependencies.tsv file when
> making changes that need newer revisions of external libraries like goose.

The juju-core change that requires this does include a dep bump to r116.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b