Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2341)

Issue 566610043: Adds missing package.json, adds --save option to npm install to ensure component is saved to node_m… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by alanmorales
Modified:
4 years, 11 months ago
Reviewers:
mkmg
Visibility:
Public.

Description

Adds missing package.json, adds --save option to npm install to ensure component is saved to node_modules.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
A package.json View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3
alanmorales
Please take a look! thanks
4 years, 11 months ago (2019-05-06 18:13:07 UTC) #1
mkmg
Thanks for making this change Alan! LGTM
4 years, 11 months ago (2019-05-06 18:15:59 UTC) #2
alanmorales
4 years, 11 months ago (2019-05-06 18:18:31 UTC) #3
On 2019/05/06 18:15:59, mkmg wrote:
> Thanks for making this change Alan! LGTM

Thanks for the quick review! adding a pull request soon
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b