Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1866)

Issue 5664046: code review 5664046: fix: add fix for gzip, zlib Writer changes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by nigeltao
Modified:
9 years ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

fix: add fix for bufio, gzip, zlib NewWriterXxx changes. Fixes issue 2979.

Patch Set 1 #

Patch Set 2 : diff -r 3e8fa8fa333f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3e8fa8fa333f https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r ff4c3628e5ba https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ff4c3628e5ba https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r ff4c3628e5ba https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 348bbad57cab https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -18 lines) Patch
M doc/go1.html View 1 2 3 4 5 7 chunks +13 lines, -9 lines 0 comments Download
M doc/go1.tmpl View 1 2 3 4 5 7 chunks +13 lines, -9 lines 0 comments Download
A src/cmd/fix/newwriter.go View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
A src/cmd/fix/newwriter_test.go View 1 2 3 4 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 8
nigeltao
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years ago (2012-02-14 07:25:36 UTC) #1
r
http://codereview.appspot.com/5664046/diff/1002/src/cmd/fix/gzip.go File src/cmd/fix/gzip.go (right): http://codereview.appspot.com/5664046/diff/1002/src/cmd/fix/gzip.go#newcode26 src/cmd/fix/gzip.go:26: func gzip(f *ast.File) bool { with a small change ...
9 years ago (2012-02-14 11:42:51 UTC) #2
nigeltao
http://codereview.appspot.com/5664046/diff/1002/src/cmd/fix/gzip.go File src/cmd/fix/gzip.go (right): http://codereview.appspot.com/5664046/diff/1002/src/cmd/fix/gzip.go#newcode26 src/cmd/fix/gzip.go:26: func gzip(f *ast.File) bool { On 2012/02/14 11:42:51, r ...
9 years ago (2012-02-15 03:21:15 UTC) #3
r
code is good but please update go1.tmpl to state that gofix does the bufio change
9 years ago (2012-02-15 03:23:36 UTC) #4
r
code is good but please update go1.tmpl to state that gofix does the bufio change
9 years ago (2012-02-15 03:23:37 UTC) #5
nigeltao
On 15 February 2012 14:23, <r@golang.org> wrote: > code is good but please update go1.tmpl ...
9 years ago (2012-02-15 03:33:36 UTC) #6
r
LGTM
9 years ago (2012-02-15 03:36:54 UTC) #7
nigeltao
9 years ago (2012-02-15 03:41:53 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=43cf9b39b647 ***

fix: add fix for bufio, gzip, zlib NewWriterXxx changes.

Fixes issue 2979.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5664046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b