Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(222)

Issue 56640044: added amulet testing scaffold

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by lazypower
Modified:
8 years, 3 months ago
Reviewers:
mp+203560, mbruzek, Marco Ceppi
Visibility:
Public.

Description

added amulet testing scaffold Deploys a set similar to the bundle, with 2 shards, a mongo shell, and configserver. Tests reachability of the ManagementUI, and accessability between nodes, validates setup by issuing service mongodb status https://code.launchpad.net/~lazypower/charms/precise/mongodb/tests/+merge/203560 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : added amulet testing scaffold #

Patch Set 3 : added amulet testing scaffold #

Total comments: 3

Patch Set 4 : added amulet testing scaffold #

Patch Set 5 : added amulet testing scaffold #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -0 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A tests/00_setup.sh View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A tests/200_deploy.test View 1 2 3 4 1 chunk +127 lines, -0 lines 0 comments Download

Messages

Total messages: 10
lazypower
Please take a look.
8 years, 3 months ago (2014-01-28 14:38:04 UTC) #1
mbruzek
Looks good Chuck. I had a few comments on the setup script. https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh File tests/00_setup.sh ...
8 years, 3 months ago (2014-01-28 16:02:06 UTC) #2
mbruzek
The python code looks good to me. +1 review from mbruzek
8 years, 3 months ago (2014-01-28 16:11:56 UTC) #3
lazypower
Thanks Matt, I responded to one of your comments, and will push the requested revisions. ...
8 years, 3 months ago (2014-01-28 16:14:34 UTC) #4
lazypower
Please take a look.
8 years, 3 months ago (2014-01-28 16:21:34 UTC) #5
lazypower
Please take a look.
8 years, 3 months ago (2014-01-28 21:52:10 UTC) #6
Marco Ceppi
I'd like to see a more extensive test. More configuration options exercised, and more relation ...
8 years, 3 months ago (2014-02-03 09:30:38 UTC) #7
lazypower
Please take a look.
8 years, 3 months ago (2014-02-03 21:50:44 UTC) #8
lazypower
Please take a look.
8 years, 3 months ago (2014-02-03 22:19:13 UTC) #9
Marco Ceppi
8 years, 3 months ago (2014-02-12 00:35:53 UTC) #10
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b