Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 565620043: Issue 5739: Add makefile targets for formatting all C++ code

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by Dan Eble
Modified:
4 years, 2 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5739/ These are not yet intended for routine use by contributors. They are meant to help explore the differences between astyle and clang-format.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M GNUmakefile.in View 1 chunk +44 lines, -0 lines 1 comment Download
M config.make.in View 1 chunk +1 line, -0 lines 0 comments Download
M configure.ac View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 3
Dan Eble
4 years, 2 months ago (2020-02-05 16:49:34 UTC) #1
dak
https://codereview.appspot.com/565620043/diff/549530043/GNUmakefile.in File GNUmakefile.in (right): https://codereview.appspot.com/565620043/diff/549530043/GNUmakefile.in#newcode319 GNUmakefile.in:319: ## TODO: This condition speeds up make when formatting ...
4 years, 2 months ago (2020-02-05 17:52:20 UTC) #2
Dan Eble
4 years, 2 months ago (2020-02-05 19:23:04 UTC) #3
On 2020/02/05 17:52:20, dak wrote:
> configure.ac:367: STEPMAKE_PROGS(CLANG_FORMAT, clang-format-9 clang-format,
> OPTIONAL, 9, 9)
> Interesting.  This gives a warning when it isn't installed?  I think that we
> don't usually flag dependencies of components not involved in either building
or
> running LilyPond.  For example, we provide Emacs and vi style files without
> checking for availability of either editor.

Yes, it gives a warning.  If this is a problem, IMO its is a shortcoming of the
configuration system: failing to distinguish between simply optional programs
and strongly recommended programs.  There's a similar issue with tidy.  If it's
there, we want to take advantage of it, but warning the dev that it is missing
is a nuisance.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b