Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5065)

Issue 565260043: flask_tryton: Retry all request on any DatabaseOperationError

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by pokoli
Modified:
1 week ago
Reviewers:
ced
Visibility:
Public.

Description

bug10

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add retry loop on all the wrapper #

Total comments: 2

Patch Set 3 : Make retry global and use decorator #

Total comments: 8

Patch Set 4 : Fix remarks #

Total comments: 3

Patch Set 5 : Make decorator a function and update changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -32 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M flask_tryton.py View 1 2 3 4 4 chunks +51 lines, -32 lines 0 comments Download

Messages

Total messages: 11
pokoli
1 week, 4 days ago (2019-11-26 14:48:21 UTC) #1
ced
I'm wondering if would not be better to decorate the all wrapper with a retry ...
1 week, 4 days ago (2019-11-26 15:13:05 UTC) #2
pokoli
Add retry loop on all the wrapper
1 week, 4 days ago (2019-11-26 19:47:19 UTC) #3
ced
https://codereview.appspot.com/565260043/diff/553220043/flask_tryton.py File flask_tryton.py (right): https://codereview.appspot.com/565260043/diff/553220043/flask_tryton.py#newcode160 flask_tryton.py:160: retry = int(config['retry']) I think retry could be stored ...
1 week, 4 days ago (2019-11-26 21:01:10 UTC) #4
pokoli
Make retry global and use decorator
1 week, 3 days ago (2019-11-27 16:55:41 UTC) #5
ced
I think we need a changelog entry. https://codereview.appspot.com/565260043/diff/555030043/flask_tryton.py File flask_tryton.py (right): https://codereview.appspot.com/565260043/diff/555030043/flask_tryton.py#newcode31 flask_tryton.py:31: retry = ...
1 week, 3 days ago (2019-11-27 18:55:36 UTC) #6
pokoli
Fix remarks
1 week, 2 days ago (2019-11-28 17:09:40 UTC) #7
pokoli
https://codereview.appspot.com/565260043/diff/555030043/flask_tryton.py File flask_tryton.py (right): https://codereview.appspot.com/565260043/diff/555030043/flask_tryton.py#newcode31 flask_tryton.py:31: retry = config.getint('database', 'retry') On 2019/11/27 18:55:35, ced wrote: ...
1 week, 2 days ago (2019-11-28 17:14:00 UTC) #8
ced
https://codereview.appspot.com/565260043/diff/555040043/CHANGELOG File CHANGELOG (right): https://codereview.appspot.com/565260043/diff/555040043/CHANGELOG#newcode1 CHANGELOG:1: * Add retry transacation decorator transaction https://codereview.appspot.com/565260043/diff/555040043/CHANGELOG#newcode1 CHANGELOG:1: * ...
1 week, 1 day ago (2019-11-28 23:17:55 UTC) #9
pokoli
Make decorator a function and update changelog
1 week ago (2019-11-30 17:33:30 UTC) #10
ced
1 week ago (2019-11-30 22:30:55 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b