code review 5646055: cmd/dist: make 'make' quieter for developers

cmd/dist: make 'make' quieter for developers

[rsc, 2012-02-08 19:57:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-02-08 20:01:23]

LGTM

On Wed, Feb 8, 2012 at 11:57 AM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/dist: make 'make' quieter for developers
>
> Please review this at http://codereview.appspot.com/5646055/
>
> Affected files:
>  M src/Make.dist
>  M src/cmd/dist/build.c
>  M src/cmd/dist/unix.c
>
>
> Index: src/Make.dist
> ===================================================================
> --- a/src/Make.dist
> +++ b/src/Make.dist
> @@ -3,12 +3,16 @@
>  # license that can be found in the LICENSE file.
>
>  # Run go tool dist to install a command.
> +# The -v causes dist to print the name of each directory as it runs.
>  # The -vv causes dist to print each build command as it runs.
>  # go tool dist clean cleans all directories, not just this one,
>  # but it's as close as we can get.
>
>  # Default target (first).
>  install:
> +       go tool dist install -v
> +
> +verbose:
>        go tool dist install -vv
>
>  clean:
> Index: src/cmd/dist/build.c
> ===================================================================
> --- a/src/cmd/dist/build.c
> +++ b/src/cmd/dist/build.c
> @@ -501,6 +501,9 @@
>        Time ttarg, t;
>        int i, j, k, n, doclean;
>
> +       if(vflag)
> +               xprintf("%s\n", dir);
> +
>        binit(&b);
>        binit(&b1);
>        binit(&path);
> @@ -1242,7 +1245,6 @@
>  {
>        int i;
>        Buf b;
> -       char *p;
>
>        ARGBEGIN{
>        case 'v':
> @@ -1259,12 +1261,8 @@
>        setup();
>
>        binit(&b);
> -       for(i=0; i<nelem(buildorder); i++) {
> -               p = bprintf(&b, buildorder[i], gochar);
> -               if(vflag > 0)
> -                       xprintf("%s\n", p);
> -               install(p);
> -       }
> +       for(i=0; i<nelem(buildorder); i++)
> +               install(bprintf(&b, buildorder[i], gochar));
>        bfree(&b);
>  }
>
> Index: src/cmd/dist/unix.c
> ===================================================================
> --- a/src/cmd/dist/unix.c
> +++ b/src/cmd/dist/unix.c
> @@ -386,7 +386,7 @@
>  void
>  xremove(char *p)
>  {
> -       if(vflag > 1)
> +       if(vflag > 2)
>                xprintf("rm %s\n", p);
>        unlink(p);
>  }
> @@ -408,11 +408,11 @@
>                        bprintf(&b, "%s/%s", p, dir.p[i]);
>                        xremoveall(bstr(&b));
>                }
> -               if(vflag > 1)
> +               if(vflag > 2)
>                        xprintf("rm %s\n", p);
>                rmdir(p);
>        } else {
> -               if(vflag > 1)
> +               if(vflag > 2)
>                        xprintf("rm %s\n", p);
>                unlink(p);
>        }
>
>

[rsc, 2012-02-08 20:26:50]

*** Submitted as http://code.google.com/p/go/source/detail?r=640ad369a382 ***

cmd/dist: make 'make' quieter for developers

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5646055

[innnzzz6, 2019-03-11 03:41:26]

Issue 5646055: code review 5646055: cmd/dist: make 'make' quieter for developers
(Closed)

[innnzzz6, 2019-03-11 03:41:27]

Issue 5646055: code review 5646055: cmd/dist: make 'make' quieter for developers
(Closed)