Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7523)

Issue 56440043: Update clock dart packaged app example for a modern Dart (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by tapted
Modified:
10 years, 3 months ago
Reviewers:
CC:
chrome-apps-internsyd_google.com
Base URL:
git://github.com/GoogleChrome/chrome-app-samples.git@master
Visibility:
Public.

Description

Update clock dart packaged app example for a modern dart. This change allows the clock to run in Dartium m31, or in Chrome, without changes. Changes: dart2js no longer accepts --disallow-unsafe-eval window.requestLayoutFrame is now scheudleMicrotask from dart:async. Date is now DateTime List<E>.filter is now List<E>.removeWhere String.charCodeAt is now String.codeUnitAt js/interop stuff no longer required Bugfix: Fix numbers not showing up at all when first opened, e.g., at exactly 4pm and now.minute == 0. Committed: https://github.com/tapted/chrome-app-samples/commit/7de7066

Patch Set 1 #

Patch Set 2 : fix some bugs #

Patch Set 3 : Add precompiled javascript so that it still works standalone in Chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11637 lines, -8501 lines) Patch
D dart/build/clock.dart.js View 1 chunk +0 lines, -8146 lines 0 comments Download
D dart/build/clock.dart.js.deps View 1 chunk +0 lines, -75 lines 0 comments Download
D dart/build/clock.dart.js.map View 1 chunk +0 lines, -6 lines 0 comments Download
M dart/clock.html View 1 1 chunk +8 lines, -2 lines 0 comments Download
M dart/compile.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/dart/balls.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M dart/dart/clock.dart View 1 4 chunks +8 lines, -7 lines 0 comments Download
A dart/dart/clock.dart.precompiled.js View 1 2 1 chunk +11573 lines, -0 lines 0 comments Download
M dart/dart/numbers.dart View 1 chunk +1 line, -1 line 0 comments Download
A dart/js/browser_dart_csp_safe.js View 1 1 chunk +36 lines, -0 lines 0 comments Download
D dart/js/dart.js View 1 chunk +0 lines, -257 lines 0 comments Download
A dart/pubspec.yaml View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
tapted
Committed patchset #1 manually as r6ae212c.
10 years, 3 months ago (2014-01-24 04:22:45 UTC) #1
tapted
10 years, 3 months ago (2014-01-24 05:22:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r7de7066.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b