Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(773)

Issue 5641054: zookeeper: turn off logging by default

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by rog
Modified:
10 years, 3 months ago
Reviewers:
mp+92040
Visibility:
Public.

Description

Turn off logging by default. Also make tests work, and time out test dialling. https://code.launchpad.net/~rogpeppe/gozk/quieten/+merge/92040 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : zookeeper: turn off logging by default #

Total comments: 7

Patch Set 3 : zookeeper: turn off logging by default #

Patch Set 4 : zookeeper: turn off logging by default #

Patch Set 5 : zookeeper: turn off logging by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M reattach_test.go View 1 2 3 3 chunks +21 lines, -16 lines 0 comments Download
M suite_test.go View 1 2 3 1 chunk +10 lines, -8 lines 0 comments Download
M zk.go View 1 2 3 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10
rog
Please take a look.
10 years, 3 months ago (2012-02-08 14:38:14 UTC) #1
rog
Please take a look.
10 years, 3 months ago (2012-02-08 14:38:51 UTC) #2
niemeyer
https://codereview.appspot.com/5641054/diff/2001/reattach_test.go File reattach_test.go (right): https://codereview.appspot.com/5641054/diff/2001/reattach_test.go#newcode135 reattach_test.go:135: conn, _ := dialWithTimeout(c, s.zkAddr, 5e9) Just use s.init() ...
10 years, 3 months ago (2012-02-10 12:23:57 UTC) #3
rog
https://codereview.appspot.com/5641054/diff/2001/reattach_test.go File reattach_test.go (right): https://codereview.appspot.com/5641054/diff/2001/reattach_test.go#newcode135 reattach_test.go:135: conn, _ := dialWithTimeout(c, s.zkAddr, 5e9) On 2012/02/10 12:23:58, ...
10 years, 3 months ago (2012-02-10 13:08:03 UTC) #4
niemeyer
https://codereview.appspot.com/5641054/diff/2001/reattach_test.go File reattach_test.go (right): https://codereview.appspot.com/5641054/diff/2001/reattach_test.go#newcode135 reattach_test.go:135: conn, _ := dialWithTimeout(c, s.zkAddr, 5e9) > i can't ...
10 years, 3 months ago (2012-02-10 13:16:05 UTC) #5
rog
Please take a look.
10 years, 3 months ago (2012-02-10 13:32:15 UTC) #6
rog
PTAL https://codereview.appspot.com/5641054/diff/2001/reattach_test.go File reattach_test.go (right): https://codereview.appspot.com/5641054/diff/2001/reattach_test.go#newcode135 reattach_test.go:135: conn, _ := dialWithTimeout(c, s.zkAddr, 5e9) On 2012/02/10 ...
10 years, 3 months ago (2012-02-10 13:32:51 UTC) #7
rog
Please take a look.
10 years, 3 months ago (2012-02-10 13:33:52 UTC) #8
niemeyer
LGTM
10 years, 3 months ago (2012-02-10 15:56:03 UTC) #9
rog
10 years, 3 months ago (2012-02-13 11:15:29 UTC) #10
*** Submitted:

zookeeper: turn off logging by default

Turn off logging by default.
Also make tests work, and time out test dialling.

R=niemeyer
CC=
https://codereview.appspot.com/5641054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b