zookeeper: turn off logging by default

Turn off logging by default.
Also make tests work, and time out test dialling.

https://code.launchpad.net/~rogpeppe/gozk/quieten/+merge/92040

(do not edit description out of merge proposal)

[rog, 2012-02-08 14:38:14]

Please take a look.

[rog, 2012-02-08 14:38:51]

Please take a look.

[niemeyer, 2012-02-10 12:23:57]

https://codereview.appspot.com/5641054/diff/2001/reattach_test.go
File reattach_test.go (right):

https://codereview.appspot.com/5641054/diff/2001/reattach_test.go#newcode135
reattach_test.go:135: conn, _ := dialWithTimeout(c, s.zkAddr, 5e9)
Just use s.init() here?

https://codereview.appspot.com/5641054/diff/2001/suite_test.go
File suite_test.go (right):

https://codereview.appspot.com/5641054/diff/2001/suite_test.go#newcode34
suite_test.go:34: conn, watch := dialWithTimeout(c, s.zkAddr, 5e9)
It's not clear why this is changing. Just use s.init() in reattach_test.go, and
preserve this as it was?

[rog, 2012-02-10 13:08:03]

https://codereview.appspot.com/5641054/diff/2001/reattach_test.go
File reattach_test.go (right):

https://codereview.appspot.com/5641054/diff/2001/reattach_test.go#newcode135
reattach_test.go:135: conn, _ := dialWithTimeout(c, s.zkAddr, 5e9)
On 2012/02/10 12:23:58, niemeyer wrote:
> Just use s.init() here?

i thnik there's a reason i wasn't using s.init before - i don't want to keep the
Conn around until the end of the test, as there's a possibility that it might
interfere with the starting and stopping tests.

i can't quite decide if that's a real possibility or not. if you think it's
fine, then yeah i'll call s.init here.

https://codereview.appspot.com/5641054/diff/2001/suite_test.go
File suite_test.go (right):

https://codereview.appspot.com/5641054/diff/2001/suite_test.go#newcode34
suite_test.go:34: conn, watch := dialWithTimeout(c, s.zkAddr, 5e9)
On 2012/02/10 12:23:58, niemeyer wrote:
> It's not clear why this is changing. Just use s.init() in reattach_test.go,
and
> preserve this as it was?

i'd want to change it anyway, as the connection needs to time out. if you still
think it's appropriate to use s.init in reattach_test.go, then i'll change this
to time out.

[niemeyer, 2012-02-10 13:16:05]

https://codereview.appspot.com/5641054/diff/2001/reattach_test.go
File reattach_test.go (right):

https://codereview.appspot.com/5641054/diff/2001/reattach_test.go#newcode135
reattach_test.go:135: conn, _ := dialWithTimeout(c, s.zkAddr, 5e9)
> i can't quite decide if that's a real possibility or not. if you think it's
> fine, then yeah i'll call s.init here.

It's just running a Get on the stock zk server prepared by the suite. I can't
see a reason either.

https://codereview.appspot.com/5641054/diff/2001/suite_test.go
File suite_test.go (right):

https://codereview.appspot.com/5641054/diff/2001/suite_test.go#newcode34
suite_test.go:34: conn, watch := dialWithTimeout(c, s.zkAddr, 5e9)
On 2012/02/10 13:08:03, rog wrote:
> On 2012/02/10 12:23:58, niemeyer wrote:
> > It's not clear why this is changing. Just use s.init() in reattach_test.go,
> and
> > preserve this as it was?
> 
> i'd want to change it anyway, as the connection needs to time out. if you
still
> think it's appropriate to use s.init in reattach_test.go, then i'll change
this
> to time out.

Sounds good.

[rog, 2012-02-10 13:32:15]

Please take a look.

[rog, 2012-02-10 13:32:51]

PTAL

https://codereview.appspot.com/5641054/diff/2001/reattach_test.go
File reattach_test.go (right):

https://codereview.appspot.com/5641054/diff/2001/reattach_test.go#newcode135
reattach_test.go:135: conn, _ := dialWithTimeout(c, s.zkAddr, 5e9)
On 2012/02/10 13:16:05, niemeyer wrote:
> > i can't quite decide if that's a real possibility or not. if you think it's
> > fine, then yeah i'll call s.init here.
> 
> It's just running a Get on the stock zk server prepared by the suite. I can't
> see a reason either.

it's not what it does, but the fact that the connection will not be closed until
after the test. i'll change it anyway, it should be fine.

[rog, 2012-02-10 13:33:52]

Please take a look.

[niemeyer, 2012-02-10 15:56:03]

LGTM

[rog, 2012-02-13 11:15:29]

*** Submitted:

zookeeper: turn off logging by default

Turn off logging by default.
Also make tests work, and time out test dialling.

R=niemeyer
CC=
https://codereview.appspot.com/5641054