Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(876)

Issue 56370043: Auto start for lxc containers

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by waigani
Modified:
10 years, 2 months ago
Reviewers:
axw, mp+202974, fwereade, thumper
Visibility:
Public.

Description

Auto start for lxc containers Auto start for lxc containers should now work on Trusty. Symlink is created if /etc/lxc/auto exists, otherwise auto start is set to true in lxc config. https://code.launchpad.net/~waigani/juju-core/lxc-trusty-autostart/+merge/202974 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M container/lxc/lxc.go View 2 chunks +13 lines, -6 lines 3 comments Download
M container/lxc/lxc_test.go View 1 chunk +19 lines, -0 lines 0 comments Download
A container/lxc/restart.go View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9
waigani
Please take a look.
10 years, 2 months ago (2014-01-24 01:37:11 UTC) #1
axw
LGTM with comment embellishment https://codereview.appspot.com/56370043/diff/1/container/lxc/lxc.go File container/lxc/lxc.go (right): https://codereview.appspot.com/56370043/diff/1/container/lxc/lxc.go#newcode112 container/lxc/lxc.go:112: // Now symlink the config ...
10 years, 2 months ago (2014-01-24 02:19:17 UTC) #2
fwereade
Nice, LGTM, please remember to link the bug to your branch: https://bugs.launchpad.net/juju-core/+bug/1271941
10 years, 2 months ago (2014-01-24 14:52:20 UTC) #3
fwereade
On 2014/01/24 14:52:20, fwereade wrote: > Nice, LGTM, please remember to link the bug to ...
10 years, 2 months ago (2014-01-24 14:53:50 UTC) #4
waigani
On 2014/01/24 14:53:50, fwereade wrote: > On 2014/01/24 14:52:20, fwereade wrote: > > Nice, LGTM, ...
10 years, 2 months ago (2014-01-26 21:06:56 UTC) #5
thumper
On 2014/01/24 14:53:50, fwereade wrote: > On 2014/01/24 14:52:20, fwereade wrote: > > Nice, LGTM, ...
10 years, 2 months ago (2014-01-26 22:50:06 UTC) #6
thumper
https://codereview.appspot.com/56370043/diff/1/container/lxc/lxc.go File container/lxc/lxc.go (right): https://codereview.appspot.com/56370043/diff/1/container/lxc/lxc.go#newcode112 container/lxc/lxc.go:112: // Now symlink the config file into the restart ...
10 years, 2 months ago (2014-01-26 22:54:54 UTC) #7
waigani
https://codereview.appspot.com/56370043/diff/1/container/lxc/lxc.go File container/lxc/lxc.go (right): https://codereview.appspot.com/56370043/diff/1/container/lxc/lxc.go#newcode112 container/lxc/lxc.go:112: // Now symlink the config file into the restart ...
10 years, 2 months ago (2014-01-26 22:56:00 UTC) #8
fwereade
10 years, 2 months ago (2014-01-27 08:07:57 UTC) #9
LGTM in light of the explanation, thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b