Issue 563650043: Don't add . to PATH in Make

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 563650043: Don't add . to PATH in Make

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 1 month ago by dak

Modified:
4 years, 1 month ago

Reviewers:
lemzwerg, hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Don't add . to PATH in Make That was apparently done by accident and may draw unexpected executable files into the action.

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	make/lilypond-vars.make	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hanwenn

4 years, 1 month ago (2020-03-04 08:07:19 UTC) #3

On 2020/03/04 07:54:46, hanwenn wrote:
> LGTM

Can you update the commit message though? I don't think there is a security
problem here.

Adding . in $PATH is a security problem on multi-user systems. In the context of
the build, you can regard this from two angles:

- you're executing in a known environment (ie. the build or src dir), so the
multi-user concern doesn't hold

- you're executing build commands that were probably downloaded from a
potentially untrusted source, so you're SOL anyway.

Expand All Messages | Collapse All Messages