manual: mark specified host as a public address

manual: mark specified host as a public address

Recent work to have machine agents publish their machine addresses has caused
a problem for the manual provider. The bootstrap node currently does not
record the host/IP bootstrapped with as being public, and so any machine
address that comes along may override it as being the "most public address".

I have changed manual provisioning/bootstrap to mark the address we
specified explicitly as being public.

Fixes #1274018

https://code.launchpad.net/~axwalk/juju-core/lp1274018-manual-provider-addresses/+merge/203689

(do not edit description out of merge proposal)

[axw, 2014-01-29 09:52:10]

Please take a look.

[wallyworld, 2014-01-30 02:20:01]

LGTM but it seems we would want a test to ensure the correct IP address is being
marked as public. Or is there a test there that I'm missing?

https://codereview.appspot.com/56310044/diff/1/environs/manual/provisioner.go
File environs/manual/provisioner.go (right):

https://codereview.appspot.com/56310044/diff/1/environs/manual/provisioner.go...
environs/manual/provisioner.go:258: logger.Infof("addresses for %v: %v",
hostname, addrs)
The above block of code is pretty much duplicated in null/instance.go, but the
version here is missing the comment. Is it worth extracting to a shared
function. How do we know the last address is the public one?

[axw, 2014-01-30 03:23:08]

Please take a look.

https://codereview.appspot.com/56310044/diff/1/environs/manual/provisioner.go
File environs/manual/provisioner.go (right):

https://codereview.appspot.com/56310044/diff/1/environs/manual/provisioner.go...
environs/manual/provisioner.go:258: logger.Infof("addresses for %v: %v",
hostname, addrs)
On 2014/01/30 02:20:01, wallyworld wrote:
> The above block of code is pretty much duplicated in null/instance.go, but the
> version here is missing the comment. Is it worth extracting to a shared
> function.

I've made a common environs/manual.HostAddresses function. This calls
instance.HostAddresses and then sets the last address to be public. I've added a
test to environs/manual.

> How do we know the last address is the public one?

Only because that's how instance.HostAddresses works now. I've updated the doc
comment for HostAddresses to make it part of the contract; there's already a
test in instance/address_test.go.