code review 5629043: strings: add Fields example

strings: add Fields example

[bradfitz, 2012-02-03 18:55:43]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-02-03 18:59:58]

LGTM

%#v is fine; %q is shorter and maybe more interesting.  Either way.

[r, 2012-02-03 19:08:23]

LGTM

http://codereview.appspot.com/5629043/diff/3001/src/pkg/strings/example_test.go
File src/pkg/strings/example_test.go (right):

http://codereview.appspot.com/5629043/diff/3001/src/pkg/strings/example_test....
src/pkg/strings/example_test.go:14: fmt.Printf("Fields are: %#v",
strings.Fields("  foo bar  baz   "))
when you know it's a string, i think it's better to use a string format so the
output is more predictable. in this case, i'd go with %q, but if you insist it
be go-syntax output you can leave it as is, redundant and noisy though it is.

[bradfitz, 2012-02-03 19:15:50]

Ah, I hadn't seen %q on a []string before. That works. %#v is just my go-to
format.

On Fri, Feb 3, 2012 at 11:08 AM, <r@golang.org> wrote:

> LGTM
>
>
> http://codereview.appspot.com/**5629043/diff/3001/src/pkg/**
>
strings/example_test.go<http://codereview.appspot.com/5629043/diff/3001/src/pkg/strings/example_test.go>
> File src/pkg/strings/example_test.**go (right):
>
> http://codereview.appspot.com/**5629043/diff/3001/src/pkg/**
>
strings/example_test.go#**newcode14<http://codereview.appspot.com/5629043/diff/3001/src/pkg/strings/example_test.go#newcode14>
> src/pkg/strings/example_test.**go:14: fmt.Printf("Fields are: %#v",
>
> strings.Fields("  foo bar  baz   "))
> when you know it's a string, i think it's better to use a string format
> so the output is more predictable. in this case, i'd go with %q, but if
> you insist it be go-syntax output you can leave it as is, redundant and
> noisy though it is.
>
>
http://codereview.appspot.com/**5629043/<http://codereview.appspot.com/5629043/>
>

[bradfitz, 2012-02-03 19:17:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=2631a7b6fb8e ***

strings: add Fields example

R=golang-dev, rsc, r
CC=golang-dev
http://codereview.appspot.com/5629043

[rsc, 2012-02-03 19:33:58]

On Fri, Feb 3, 2012 at 14:15, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Ah, I hadn't seen %q on a []string before.

For aggregates like slices and maps, the format
filters down to the elements, so %q on a []string
means %q on each string; %.2f on a []float64 works too.

[r2, 2012-02-03 19:39:12]

On 04/02/2012, at 6:33 AM, Russ Cox wrote:

> On Fri, Feb 3, 2012 at 14:15, Brad Fitzpatrick <bradfitz@golang.org> wrote:
>> Ah, I hadn't seen %q on a []string before.
> 
> For aggregates like slices and maps, the format
> filters down to the elements, so %q on a []string
> means %q on each string; %.2f on a []float64 works too.

This ain't your old C printf.

-rob