Issue 5614043: code review 5614043: net/http/httputil: fix race in DumpRequestOut

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5614043: code review 5614043: net/http/httputil: fix race in DumpRequestOut (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bradfitz

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

net/http/httputil: fix race in DumpRequestOut Fixes issue 2715

Patch Set 2 : diff -r f79343c8a479 https://go.googlecode.com/hg #

Patch Set 3 : diff -r f79343c8a479 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 4f4b60443318 https://go.googlecode.com/hg #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -18 lines)			Patch
	M	src/pkg/net/http/httputil/dump.go	View	1	2 chunks	+37 lines, -18 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

12 years, 2 months ago (2012-02-01 19:00:21 UTC) #1

adg

http://codereview.appspot.com/5614043/diff/4001/src/pkg/net/http/httputil/dump.go File src/pkg/net/http/httputil/dump.go (right): http://codereview.appspot.com/5614043/diff/4001/src/pkg/net/http/httputil/dump.go#newcode91 src/pkg/net/http/httputil/dump.go:91: // delegateReader is a reader that delegates to another ...

12 years, 2 months ago (2012-02-01 22:55:03 UTC) #3

bradfitz

There's already a test. It failed before with GOMAXPROCS=16 & now it doesn't. On Wed, ...

12 years, 2 months ago (2012-02-01 23:00:09 UTC) #4

bradfitz

12 years, 2 months ago (2012-02-01 23:10:18 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=31956b697e05 ***

net/http/httputil: fix race in DumpRequestOut

Fixes issue 2715

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5614043

Expand All Messages | Collapse All Messages