Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(258)

Issue 5614043: code review 5614043: net/http/httputil: fix race in DumpRequestOut (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by bradfitz
Modified:
2 years, 2 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

net/http/httputil: fix race in DumpRequestOut

Fixes issue 2715

Patch Set 1 #

Patch Set 2 : diff -r f79343c8a479 https://go.googlecode.com/hg #

Patch Set 3 : diff -r f79343c8a479 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 4f4b60443318 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M src/pkg/net/http/httputil/dump.go View 1 2 chunks +37 lines, -18 lines 0 comments Download

Messages

Total messages: 6
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
2 years, 2 months ago #1
adg
No test?
2 years, 2 months ago #2
adg
http://codereview.appspot.com/5614043/diff/4001/src/pkg/net/http/httputil/dump.go File src/pkg/net/http/httputil/dump.go (right): http://codereview.appspot.com/5614043/diff/4001/src/pkg/net/http/httputil/dump.go#newcode91 src/pkg/net/http/httputil/dump.go:91: // delegateReader is a reader that delegates to another ...
2 years, 2 months ago #3
bradfitz
There's already a test. It failed before with GOMAXPROCS=16 & now it doesn't. On Wed, ...
2 years, 2 months ago #4
adg
LGTM Cool.
2 years, 2 months ago #5
bradfitz
2 years, 2 months ago #6
*** Submitted as http://code.google.com/p/go/source/detail?r=31956b697e05 ***

net/http/httputil: fix race in DumpRequestOut

Fixes issue 2715

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5614043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5