Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(461)

Issue 5607059: code review 5607059: go/printer: remove package comment from testdata/parser.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by adg
Modified:
2 years, 2 months ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

go/printer: remove package comment from testdata/parser.go

This prevents an incorrect summary line from appearing in the godoc
package list.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 01be17812c0f https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/go/printer/testdata/parser.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
2 years, 2 months ago #1
gri
LGTM http://codereview.appspot.com/5607059/diff/1/src/pkg/go/printer/testdata/parser.go File src/pkg/go/printer/testdata/parser.go (left): http://codereview.appspot.com/5607059/diff/1/src/pkg/go/printer/testdata/parser.go#oldcode9 src/pkg/go/printer/testdata/parser.go:9: // you could just remove this // on ...
2 years, 2 months ago #2
adg
2 years, 2 months ago #3
*** Submitted as http://code.google.com/p/go/source/detail?r=4f4b60443318 ***

go/printer: remove package comment from testdata/parser.go

This prevents an incorrect summary line from appearing in the godoc
package list.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5607059

http://codereview.appspot.com/5607059/diff/1/src/pkg/go/printer/testdata/pars...
File src/pkg/go/printer/testdata/parser.go (left):

http://codereview.appspot.com/5607059/diff/1/src/pkg/go/printer/testdata/pars...
src/pkg/go/printer/testdata/parser.go:9: //
On 2012/02/01 22:01:44, gri wrote:
> you could just remove this // on line 9 for a minimal change - this file is
used
> in a benchmark...

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5