Issue 5607059: code review 5607059: go/printer: remove package comment from testdata/parser.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5607059: code review 5607059: go/printer: remove package comment from testdata/parser.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by adg

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

go/printer: remove package comment from testdata/parser.go This prevents an incorrect summary line from appearing in the godoc package list.

Patch Set 2 : diff -r 01be17812c0f https://go.googlecode.com/hg #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/go/printer/testdata/parser.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 2 months ago (2012-02-01 21:57:11 UTC) #1

gri

LGTM http://codereview.appspot.com/5607059/diff/1/src/pkg/go/printer/testdata/parser.go File src/pkg/go/printer/testdata/parser.go (left): http://codereview.appspot.com/5607059/diff/1/src/pkg/go/printer/testdata/parser.go#oldcode9 src/pkg/go/printer/testdata/parser.go:9: // you could just remove this // on ...

12 years, 2 months ago (2012-02-01 22:01:44 UTC) #2

adg

12 years, 2 months ago (2012-02-01 22:28:17 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4f4b60443318 ***

go/printer: remove package comment from testdata/parser.go

This prevents an incorrect summary line from appearing in the godoc
package list.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5607059

http://codereview.appspot.com/5607059/diff/1/src/pkg/go/printer/testdata/pars...
File src/pkg/go/printer/testdata/parser.go (left):

http://codereview.appspot.com/5607059/diff/1/src/pkg/go/printer/testdata/pars...
src/pkg/go/printer/testdata/parser.go:9: //
On 2012/02/01 22:01:44, gri wrote:
> you could just remove this // on line 9 for a minimal change - this file is
used
> in a benchmark...

Done.

Expand All Messages | Collapse All Messages