Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10320)

Issue 559500043: Implement Grob::event_cause, Grob::ultimate_event_cause

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by dak
Modified:
4 years, 1 month ago
Reviewers:
Dan Eble, hahnjo, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Implement Grob::event_cause, Grob::ultimate_event_cause Those were implemented in Grob_info only previously which does not make a lot of sense, given that they don't access anything particular to Grob_info. Also contains commit: Use Grob::event_cause and Grob::ultimate_event_cause where useful Frankly, this one has been bugging me on and off for years. I just had one compilation error too much today.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Save one unsmob. #

Patch Set 3 : Save one iteration! SCNR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -37 lines) Patch
M lily/accidental-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/accidental-placement.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/grob.cc View 1 2 2 chunks +25 lines, -16 lines 0 comments Download
M lily/grob-info.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M lily/include/grob.hh View 2 chunks +5 lines, -0 lines 0 comments Download
M lily/lyric-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/percent-repeat-item.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/slur-engraver.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M lily/tie-engraver.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6
hahnjo
LGTM, nice cleanup
4 years, 1 month ago (2020-02-20 15:24:31 UTC) #1
hanwenn
LGTM
4 years, 1 month ago (2020-02-20 23:13:54 UTC) #2
Dan Eble
LGTM https://codereview.appspot.com/559500043/diff/559510043/lily/grob.cc File lily/grob.cc (right): https://codereview.appspot.com/559500043/diff/559510043/lily/grob.cc#newcode733 lily/grob.cc:733: while (unsmob<Grob> (cause)) I appreciate that issuing warnings ...
4 years, 1 month ago (2020-02-21 00:13:25 UTC) #3
dak
https://codereview.appspot.com/559500043/diff/559510043/lily/grob.cc File lily/grob.cc (right): https://codereview.appspot.com/559500043/diff/559510043/lily/grob.cc#newcode733 lily/grob.cc:733: while (unsmob<Grob> (cause)) On 2020/02/21 00:13:25, Dan Eble wrote: ...
4 years, 1 month ago (2020-02-21 00:32:07 UTC) #4
dak
Save one unsmob.
4 years, 1 month ago (2020-02-21 00:40:23 UTC) #5
dak
4 years, 1 month ago (2020-02-21 00:54:47 UTC) #6
Save one iteration!  SCNR
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b