Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1708)

Issue 5587050: code review 5587050: go.crypto/pbkdf2: New package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Luit
Modified:
7 years, 9 months ago
Reviewers:
CC:
agl1, rsc, golang-dev
Visibility:
Public.

Description

go.crypto/pbkdf2: New package Implements PKCS#5 v2.0 and potentially the future v2.1.

Patch Set 1 #

Patch Set 2 : diff -r 943eeb94bdc1 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 943eeb94bdc1 https://code.google.com/p/go.crypto #

Total comments: 16

Patch Set 4 : diff -r 943eeb94bdc1 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 943eeb94bdc1 https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 6 : diff -r 943eeb94bdc1 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -0 lines) Patch
A pbkdf2/pbkdf2.go View 1 2 3 4 5 1 chunk +74 lines, -0 lines 0 comments Download
A pbkdf2/pbkdf2_test.go View 1 2 3 1 chunk +157 lines, -0 lines 0 comments Download

Messages

Total messages: 16
Luit
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
7 years, 9 months ago (2012-01-31 16:14:01 UTC) #1
agl1
http://codereview.appspot.com/5587050/diff/3005/pbkdf2/pbkdf2.go File pbkdf2/pbkdf2.go (right): http://codereview.appspot.com/5587050/diff/3005/pbkdf2/pbkdf2.go#newcode37 pbkdf2/pbkdf2.go:37: therefor increases security, but choosing one that's too high ...
7 years, 9 months ago (2012-01-31 16:31:21 UTC) #2
rsc
Thanks for doing this. I am looking forward to having this in a standard place. ...
7 years, 9 months ago (2012-01-31 16:41:15 UTC) #3
Luit
On 2012/01/31 16:31:21, agl1 wrote: > http://codereview.appspot.com/5587050/diff/3005/pbkdf2/pbkdf2.go#newcode53 > pbkdf2/pbkdf2.go:53: // The returned function takes four ...
7 years, 9 months ago (2012-01-31 16:50:19 UTC) #4
rsc
On Tue, Jan 31, 2012 at 11:50, <luitvd@gmail.com> wrote: > My idea with this was ...
7 years, 9 months ago (2012-01-31 16:54:19 UTC) #5
rsc
On Tue, Jan 31, 2012 at 11:50, <luitvd@gmail.com> wrote: > This loop isn't run that ...
7 years, 9 months ago (2012-01-31 16:54:41 UTC) #6
Luit
Good points all around. Now what to call this modified function? New doesn't sound to ...
7 years, 9 months ago (2012-01-31 17:10:55 UTC) #7
rsc
On Tue, Jan 31, 2012 at 12:10, <luitvd@gmail.com> wrote: > Good points all around. Now ...
7 years, 9 months ago (2012-01-31 17:14:02 UTC) #8
Luit
Hello agl@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 9 months ago (2012-01-31 20:45:10 UTC) #9
Luit
Hello agl@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 9 months ago (2012-01-31 20:46:30 UTC) #10
agl1
LGTM. You can still save significant numbers of allocations, but I can fix that up ...
7 years, 9 months ago (2012-01-31 21:06:54 UTC) #11
Luit
On 2012/01/31 21:06:54, agl1 wrote: > LGTM. You can still save significant numbers of allocations, ...
7 years, 9 months ago (2012-01-31 21:13:53 UTC) #12
Luit
Hello agl@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 9 months ago (2012-01-31 21:14:47 UTC) #13
rsc
LGTM Leaving for agl
7 years, 9 months ago (2012-01-31 21:21:03 UTC) #14
Luit
Looking forward to agl's improvements. -Luit http://codereview.appspot.com/5587050/diff/3005/pbkdf2/pbkdf2.go File pbkdf2/pbkdf2.go (right): http://codereview.appspot.com/5587050/diff/3005/pbkdf2/pbkdf2.go#newcode37 pbkdf2/pbkdf2.go:37: therefor increases security, ...
7 years, 9 months ago (2012-02-01 12:16:27 UTC) #15
agl1
7 years, 9 months ago (2012-02-01 19:20:36 UTC) #16
*** Submitted as b5c95223a8c6 ***

go.crypto/pbkdf2: New package

Implements PKCS#5 v2.0 and potentially the future v2.1.

R=agl, rsc
CC=golang-dev
http://codereview.appspot.com/5587050

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b