solves issue #404 jinja2.exceptions.UndefinedError UndefinedError: 'fqname' is undefined Small Erro…

solves issue #404 jinja2.exceptions.UndefinedError UndefinedError: 'fqname' is undefined Small Erro…

[RogerHaase, 2014-02-10 21:11:47]

https://codereview.appspot.com/55870044/diff/1/MoinMoin/storage/middleware/pr...
File MoinMoin/storage/middleware/protecting.py (right):

https://codereview.appspot.com/55870044/diff/1/MoinMoin/storage/middleware/pr...
MoinMoin/storage/middleware/protecting.py:196: 
Your fix solves the immediate problem, but I think there is a problem upstream
somewhere.

Install pycharm if you haven't yet (or other python ide or you could do logging
or even print).  If you set a breakpoint on your new line of code, then you will
see:

If your current theme is basic or modernized, you are viewing home page and
click settings, then user settings page is displayed.

If your current theme is foobar, you are viewing home page and click settings,
then you will hit the breakpoint with an undefined fqname.

So it appears problem is the foobar theme is somehow checking for permission to
show the user settings page whereas modernized and basic are not. Can you find
the upstream problem?

[shailrishabh, 2014-02-11 15:01:56]

On 2014/02/10 21:11:47, RogerHaase wrote:
>
https://codereview.appspot.com/55870044/diff/1/MoinMoin/storage/middleware/pr...
> File MoinMoin/storage/middleware/protecting.py (right):
> 
>
https://codereview.appspot.com/55870044/diff/1/MoinMoin/storage/middleware/pr...
> MoinMoin/storage/middleware/protecting.py:196: 
> Your fix solves the immediate problem, but I think there is a problem upstream
> somewhere.
> 
> Install pycharm if you haven't yet (or other python ide or you could do
logging
> or even print).  If you set a breakpoint on your new line of code, then you
will
> see:
> 
> If your current theme is basic or modernized, you are viewing home page and
> click settings, then user settings page is displayed.
> 
> If your current theme is foobar, you are viewing home page and click settings,
> then you will hit the breakpoint with an undefined fqname.
> 
> So it appears problem is the foobar theme is somehow checking for permission
to
> show the user settings page whereas modernized and basic are not. Can you find
> the upstream problem?



Yeah in the upstream the render_template function in views.py should have sent
fqname with it when it rendered the templates itemviews.html but it wasn't
happening.

[RogerHaase, 2014-02-20 20:40:59]

Try removing the line:

{% import "itemviews.html" as itemviews with context %}

from themes/foobar/templates/layout.html and adding it to
themes/foobar/templates/show.html